quic: fix lint error in node_quic_crypto #34019
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the following lint error is generated: Running C++ linter... File "src/quic/node_quic_crypto.cc" does not use "String" make[1]: *** [Makefile:1336: tools/.cpplintstamp] Error 1 This commit removes the unused using declaration.
nodejs-github-bot
added
c++
|
Can we fast-track this? |
richardlau
approved these changes
Jun 22, 2020
jasnell
approved these changes
Jun 22, 2020
|
will land as soon as CI comes back |
jasnell
pushed a commit
that referenced
this pull request
Jun 22, 2020
Currently, the following lint error is generated: Running C++ linter... File "src/quic/node_quic_crypto.cc" does not use "String" make[1]: *** [Makefile:1336: tools/.cpplintstamp] Error 1 This commit removes the unused using declaration. PR-URL: #34019 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in adf14e2 |
This was referenced May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following lint error is generated:
This commit removes the unused using declaration.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes