doc: mention errors thrown by methods called on an unbound dgram.Socket#33983
Closed
mkrawczuk wants to merge 3 commits intonodejs:masterfrom
Closed
doc: mention errors thrown by methods called on an unbound dgram.Socket#33983mkrawczuk wants to merge 3 commits intonodejs:masterfrom
mkrawczuk wants to merge 3 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
dgram
addaleax
approved these changes
Jun 20, 2020
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
I agree, the error system is very inconsistent here, unfortunately … 😕 Thanks for the PR!
Trott
reviewed
Jun 20, 2020
Trott
reviewed
Jun 20, 2020
Trott
reviewed
Jun 20, 2020
Trott
reviewed
Jun 20, 2020
Trott
approved these changes
Jun 20, 2020
Trott
approved these changes
Jun 20, 2020
Member
|
The text is fine as is, but if you want to fine-tune it even more, here's one more optional suggestion: Instead of |
Trott
added
the
author ready
Contributor
Author
|
Yeah, let's not be satisfied with 99% correct if we can be 100% correct with almost no effort. |
trivikr
approved these changes
Jun 22, 2020
jasnell
reviewed
Jun 22, 2020
jasnell
approved these changes
Jun 22, 2020
Trott
pushed a commit
that referenced
this pull request
Jun 24, 2020
PR-URL: #33983 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 91d9cdf |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2020
PR-URL: #33983 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
PR-URL: #33983 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #33983 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on this I have discovered an inconsistency: given
dgram.Socketinstance is undbound, callingaddress()on it results in a system errorEBADFbeing thrown, while callingremoteAddress()results inERR_SOCKET_DGRAM_NOT_CONNECTED.Also, calling
send()on an unbound socket throwsERR_SOCKET_BAD_PORTwhich might also be found misguiding.These I believe are easy fixes. Once the documentation resembles the current state of things I can open another PR introducing a fix to it.
Also mentioned a side effect caused by
socket.addMembership()andsocket.addSourceSpecificMembership(). Not sure if it is desired.