Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some typos #33973

Closed
wants to merge 1 commit into from
Closed

Some typos #33973

wants to merge 1 commit into from

Conversation

falguniraina
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 19, 2020
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome, @falguniraina, and thanks for the pull request.

A little pedantic of me, but for whoever lands this: When you edit the commit message, it is more correct (in my opinion, at least) to say that these are style improvements than typos. The text is all correct as it is. This improves the text. Maybe doc: improve text in issues.md or something like that.

@falguniraina
Copy link
Contributor Author

Welcome, @falguniraina, and thanks for the pull request.

A little pedantic of me, but for whoever lands this: When you edit the commit message, it is more correct (in my opinion

Sure Sir!! I will definitely consider such things next time actually i am just a beginner in the open source contribution and trying to understand things!!

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think this could land as is but I added some suggestions as I think some of the original copy was better.

Both of my nits can be ignored

@@ -90,10 +90,10 @@ including whether the behavior being seen is a bug or a feature. This discussion
is part of the process and should be kept focused, helpful, and professional.

Short, clipped responses that provide neither additional context nor supporting
detail are not helpful or professional. To many, such responses are simply
details are not helpful or professional to many. Such responses are simply
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
details are not helpful or professional to many. Such responses are simply
details are not helpful or professional. To many, Such responses are simply

I personally prefer the original sentence break here, but details definitely needs to be pluralized

annoying and unfriendly.

Contributors are encouraged to help one another make forward progress as much
Contributors are encouraged to help one another to make forward progress as much
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Contributors are encouraged to help one another to make forward progress as much
Contributors are encouraged to help one another make forward progress as much

I don't think this change needs to be made. The original sentence is grammatically correct.

@Trott
Copy link
Member

Trott commented Jul 2, 2020

Landed in c118304

@Trott Trott closed this Jul 2, 2020
Trott pushed a commit that referenced this pull request Jul 2, 2020
PR-URL: #33973
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
PR-URL: #33973
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
PR-URL: #33973
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #33973
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants