doc: Fix the typo in example output in url.md for url.hostname #33735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
gireeshpunathil
approved these changes
Jun 5, 2020
|
Notice that you must first run
Disagree w/ the changes, but I think this example could be more clear. |
|
@DerekNonGeneric - thanks, and you are right. the @darkrishabh - this change is not correct. At the same time, I guess the doc can be improved to make it more explicit, to avoid confusion. Let me know if you can come up with a sentence. |
cjihrig
previously approved these changes
Jun 5, 2020
jasnell
reviewed
Jul 3, 2020
jasnell
reviewed
Jul 3, 2020
Co-authored-by: James M Snell <jasnell@gmail.com>
Co-authored-by: James M Snell <jasnell@gmail.com>
|
Sorry for picking this up so late, I got involved in some family emergency. I agree with @jasnell and incorporated the change suggested. |
tniessen
reviewed
Sep 5, 2020
aduh95
requested changes
Nov 8, 2020
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Nov 17, 2020
aduh95
added
the
author ready
|
Landed in 665da27 |
aduh95
pushed a commit
that referenced
this pull request
Nov 18, 2020
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the
url.hostname, the replacement example updates the hostname to useexample.com:82but in the comment it's showing the expected output for the operation to be// Prints https://example.com:81/fooIt should be
// Prints https://example.com:82/fooChecklist