Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update wasi code sample #33626

Merged
merged 0 commits into from
Jun 19, 2020
Merged

doc: update wasi code sample #33626

merged 0 commits into from
Jun 19, 2020

Conversation

pragyandas
Copy link
Contributor

wasi: update code sample

Code sample updated by adding a hello-world (demo.wat) code example. Step for compiling .wat to .wasm added (with reference to wabt tools). The sample code prints "hello world\n" in the console. Note: This update can be treated as an extension to the existing sample.

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. wasi Issues and PRs related to the WebAssembly System Interface. labels May 28, 2020
@addaleax addaleax changed the title wasi: update code sample doc: update wasi code sample May 29, 2020
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the linter failures addressed

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 30, 2020
@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18
@reklatsmasters
Copy link
Contributor

Just note. you actually don’t need wabt or wat2wasm tools. You may use webassembly extension for vscode to compile wat to wasm.

@pragyandas
Copy link
Contributor Author

pragyandas commented Jun 4, 2020

Just note. you actually don’t need wabt or wat2wasm tools. You may use webassembly extension for vscode to compile wat to wasm.

@reklatsmasters VSCode webassembly extension uses wabt as a dependency (see package.json), which is a JS port of wabt. Moreover, I don't think VSCode extension is a standard way of compiling wat to wasm, but can be an option to consider for VSCode users.

@addaleax
Copy link
Member

Landed in f5ec98c, thanks for the PR! 🎉

addaleax pushed a commit that referenced this pull request Jun 19, 2020
- Code sample updated by adding a hello-world (`demo.wat`) code example
- Step for compiling `.wat` to `.wasm` added (with reference to
  `wabt` tools)
- The sample code prints "hello world\n" in the console

Note: This update adds a very minimal change to the existing sample and
can be treated as an extension.

PR-URL: #33626
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax addaleax closed this Jun 19, 2020
@addaleax
Copy link
Member

Actually, I had to back this out of master because this conflicts with the linter rules introduced by 0ef6956

@Trott or @DerekNonGeneric Could you push a fixup commit to this PR and then land this? I’m not sure what the linter expects here myself.

@addaleax addaleax reopened this Jun 19, 2020
doc/api/wasi.md Outdated Show resolved Hide resolved
doc/api/wasi.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Jun 19, 2020

@Trott or @DerekNonGeneric Could you push a fixup commit to this PR and then land this? I’m not sure what the linter expects here myself.

I'll make a judgment call and push a fixup commit (and then land, and then open a PR to get the lint presets updated if appropriate).

doc/api/wasi.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Jun 19, 2020

Fixed-up and force-pushed.

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott
Copy link
Member

Trott commented Jun 19, 2020

All the linters came back green. Landing.

@Trott
Copy link
Member

Trott commented Jun 19, 2020

Landed in 343cf1b

@Trott Trott merged commit 343cf1b into nodejs:master Jun 19, 2020
codebytere pushed a commit that referenced this pull request Jun 27, 2020
- Code sample updated by adding a hello-world (`demo.wat`) code example
- Step for compiling `.wat` to `.wasm` added (with reference to `wabt`
  tools)
- The sample code prints "hello world\n" in the console

This update adds a very minimal change to the existing sample and can be
treated as an extension.

PR-URL: #33626
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
- Code sample updated by adding a hello-world (`demo.wat`) code example
- Step for compiling `.wat` to `.wasm` added (with reference to `wabt`
  tools)
- The sample code prints "hello world\n" in the console

This update adds a very minimal change to the existing sample and can be
treated as an extension.

PR-URL: #33626
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
- Code sample updated by adding a hello-world (`demo.wat`) code example
- Step for compiling `.wat` to `.wasm` added (with reference to `wabt`
  tools)
- The sample code prints "hello world\n" in the console

This update adds a very minimal change to the existing sample and can be
treated as an extension.

PR-URL: #33626
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 12, 2020
- Code sample updated by adding a hello-world (`demo.wat`) code example
- Step for compiling `.wat` to `.wasm` added (with reference to `wabt`
  tools)
- The sample code prints "hello world\n" in the console

This update adds a very minimal change to the existing sample and can be
treated as an extension.

PR-URL: #33626
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
codebytere pushed a commit that referenced this pull request Jul 14, 2020
- Code sample updated by adding a hello-world (`demo.wat`) code example
- Step for compiling `.wat` to `.wasm` added (with reference to `wabt`
  tools)
- The sample code prints "hello world\n" in the console

This update adds a very minimal change to the existing sample and can be
treated as an extension.

PR-URL: #33626
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. wasi Issues and PRs related to the WebAssembly System Interface.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants