Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: support dispatching event from event #33624

Closed
wants to merge 5 commits into from
Closed

events: support dispatching event from event #33624

wants to merge 5 commits into from

Commits on Jun 21, 2020

  1. event: cancelBubble is a property 

    Event#cancelBubble is property (and not a function). Change
Event#cancelBubble to a property and add a test.

PR-URL: nodejs#33613
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    @benjamingr
    benjamingr authored and Benjamin Gruenbaum committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    3fff349 View commit details
    Browse the repository at this point in the history

  2. events: add event-target tests 

    PR-URL: nodejs#33623
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @benjamingr
    benjamingr authored and Benjamin Gruenbaum committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    d2b9e56 View commit details
    Browse the repository at this point in the history

  3. events: support dispatching event from event

    @benjamingr
    benjamingr authored and Benjamin Gruenbaum committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    331d904 View commit details
    Browse the repository at this point in the history

  4. fixup! ruben's fix again

    Benjamin Gruenbaum authored and Benjamin Gruenbaum committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    2f7d424 View commit details
    Browse the repository at this point in the history

  5. fix lint

    Benjamin Gruenbaum authored and Benjamin Gruenbaum committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    5b397ab View commit details
    Browse the repository at this point in the history