events: cancelBubble is a property #33613

benjamingr · 2020-05-28T14:35:17Z

Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

targos · 2020-05-28T14:39:42Z

I'd be in favor of implementing these properties by following the spec: https://dom.spec.whatwg.org/#stop-propagation-flag
That would mean that cancelBubble should use a private "stop propagation flag"

jasnell · 2020-05-28T14:41:24Z

Yeah, even tho we're not making use of this at all, we should at least preserve the value of the flag.

benjamingr · 2020-05-28T14:41:48Z

@targos ok, I'll update this to reflect the flag.

benjamingr · 2020-05-28T14:56:25Z

@targos I pushed a property and added some tests to check the behavior. Still definitely not perfect, I would eventually like to run better tests on this (following the guide), I am starting by doing a shallow run now to get familiarized with the code - and so there are a bunch of small PRs rather than a large-ish one for compatibility.

nodejs-github-bot · 2020-05-28T16:43:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31611/

jasnell · 2020-05-28T16:49:09Z

@benjamingr ... thank you for going through these, btw... it would have been at least a week before I would have been able to get back to it.

Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: #33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

benjamingr · 2020-05-31T10:22:54Z

~~Landed in f643cf4~~

nodejs-github-bot · 2020-05-31T13:31:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31678/

nodejs-github-bot · 2020-06-01T14:57:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31686/

nodejs-github-bot · 2020-06-03T17:11:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31705/

jasnell · 2020-06-03T21:35:38Z

@benjamingr ... this needs a rebase

benjamingr · 2020-06-04T09:48:25Z

rebased

Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test.

nodejs-github-bot · 2020-06-04T13:33:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31719/

Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: #33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

jasnell · 2020-06-04T17:43:36Z

Landed in 3128915

Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: #33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: nodejs#33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: #33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #34015 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: #33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: #33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #34015 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

benjamingr requested a review from jasnell May 28, 2020 14:35

benjamingr added the events Issues and PRs related to the events subsystem / EventEmitter. label May 28, 2020

benjamingr changed the title ~~event: cancelBubble is a property~~ events: cancelBubble is a property May 28, 2020

benjamingr force-pushed the event-target-cancel-bubble branch from 92aaaf3 to 7d25bf5 Compare May 28, 2020 14:53

jasnell approved these changes May 28, 2020

View reviewed changes

targos approved these changes May 28, 2020

View reviewed changes

BridgeAR approved these changes May 28, 2020

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 28, 2020

juanarbol approved these changes May 28, 2020

View reviewed changes

benjamingr mentioned this pull request May 29, 2020

events: improve argument handling, start passive #33637

Closed

4 tasks

benjamingr force-pushed the event-target-cancel-bubble branch from 1a827f4 to a1064d5 Compare May 31, 2020 10:21

benjamingr closed this May 31, 2020

benjamingr deleted the event-target-cancel-bubble branch May 31, 2020 10:22

benjamingr restored the event-target-cancel-bubble branch May 31, 2020 12:11

BridgeAR reopened this May 31, 2020

BridgeAR force-pushed the master branch from 8ae28ff to 2935f72 Compare May 31, 2020 12:18

lundibundi mentioned this pull request May 31, 2020

events: EventTarget use validators and small fix #33663

Closed

2 tasks

BridgeAR force-pushed the event-target-cancel-bubble branch from d65c8d1 to b1ba21f Compare May 31, 2020 13:31

benjamingr force-pushed the event-target-cancel-bubble branch from b1ba21f to 9f28785 Compare June 4, 2020 09:49

benjamingr added 2 commits June 4, 2020 12:51

event: cancelBubble is a property

cb3a9ac

Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test.

fixup! set actual properties

412d82d

benjamingr force-pushed the event-target-cancel-bubble branch from 9f28785 to 412d82d Compare June 4, 2020 09:51

This was referenced Jun 4, 2020

CI Relability 2020-06-04 JaneaSystems/nodejs-reliability#3

Closed

CI Relability 2020-06-04 JaneaSystems/nodejs-reliability#4

Open

lundibundi approved these changes Jun 4, 2020

View reviewed changes

jasnell closed this Jun 4, 2020

This was referenced Jun 5, 2020

CI Relability 2020-06-05 JaneaSystems/nodejs-reliability#5

Open

CI Relability 2020-06-06 JaneaSystems/nodejs-reliability#6

Open

CI Relability 2020-06-07 JaneaSystems/nodejs-reliability#7

Open

CI Relability 2020-06-08 JaneaSystems/nodejs-reliability#8

Open

codebytere mentioned this pull request Jun 28, 2020

v14.5.0 proposal #34093

Merged

addaleax mentioned this pull request Sep 22, 2020

events: initial implementation of experimental EventTarget #33556

Closed

4 tasks

addaleax added the backport-requested-v12.x label Sep 22, 2020

Scout2012 mentioned this pull request Dec 6, 2023

events: setting Event.cancelBubble calls stopPropagation #50401

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

events: cancelBubble is a property #33613

events: cancelBubble is a property #33613

benjamingr commented May 28, 2020

targos commented May 28, 2020

jasnell commented May 28, 2020

benjamingr commented May 28, 2020

benjamingr commented May 28, 2020

nodejs-github-bot commented May 28, 2020

jasnell commented May 28, 2020

benjamingr commented May 31, 2020 •

edited by BridgeAR

Loading

nodejs-github-bot commented May 31, 2020

nodejs-github-bot commented Jun 1, 2020

nodejs-github-bot commented Jun 3, 2020

jasnell commented Jun 3, 2020

benjamingr commented Jun 4, 2020

nodejs-github-bot commented Jun 4, 2020

jasnell commented Jun 4, 2020

events: cancelBubble is a property #33613

events: cancelBubble is a property #33613

Conversation

benjamingr commented May 28, 2020

Checklist

targos commented May 28, 2020

jasnell commented May 28, 2020

benjamingr commented May 28, 2020

benjamingr commented May 28, 2020

nodejs-github-bot commented May 28, 2020

jasnell commented May 28, 2020

benjamingr commented May 31, 2020 • edited by BridgeAR Loading

nodejs-github-bot commented May 31, 2020

nodejs-github-bot commented Jun 1, 2020

nodejs-github-bot commented Jun 3, 2020

jasnell commented Jun 3, 2020

benjamingr commented Jun 4, 2020

nodejs-github-bot commented Jun 4, 2020

jasnell commented Jun 4, 2020

benjamingr commented May 31, 2020 •

edited by BridgeAR

Loading