Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix stream example #33426

Closed
wants to merge 1 commit into from
Closed

doc: fix stream example #33426

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

  • Un-break the code for multibyte characters
  • Get fs.createReadStream from the right module
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax
doc: fix stream example
ba508f5 
- Un-break the code for multibyte characters
- Get `fs.createReadStream` from the right module
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels May 15, 2020
mcollina
mcollina approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 15, 2020
@MylesBorins
Copy link
Contributor

fastrack?

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label May 16, 2020
@addaleax
Copy link
Member Author

Landed in 0f232ed, thanks for the quick reviews :)

@addaleax addaleax closed this May 16, 2020
addaleax added a commit that referenced this pull request May 16, 2020
@addaleax
doc: fix stream example
0f232ed 
- Un-break the code for multibyte characters
- Get `fs.createReadStream` from the right module

PR-URL: #33426
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@addaleax addaleax deleted the stream-example-setencoding branch May 16, 2020 00:29
codebytere pushed a commit that referenced this pull request May 16, 2020
@addaleax @codebytere
doc: fix stream example
8f91338 
- Un-break the code for multibyte characters
- Get `fs.createReadStream` from the right module

PR-URL: #33426
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @MylesBorins @mcollina @cjihrig @devsnek @codebytere @nodejs-github-bot