Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: Delete unused variables to resolve compile time print warning #33358

Closed
wants to merge 1 commit into from
Closed

src: Delete unused variables to resolve compile time print warning #33358

wants to merge 1 commit into from

Conversation

rickyes
Copy link
Contributor

@rickyes rickyes commented May 11, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 11, 2020
@richardlau richardlau mentioned this pull request May 11, 2020
Merged
2 tasks
@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31284/

@addaleax
Copy link
Member

CI is yellow, 👍 to fast-track?

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label May 12, 2020
richardlau pushed a commit that referenced this pull request May 12, 2020
@rickyes @richardlau
src: delete unused variables to resolve compile time print warning
aee36a0 
PR-URL: #33358
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@richardlau
Copy link
Member

Landed in aee36a0.

@richardlau richardlau closed this May 12, 2020
@rickyes rickyes deleted the remove-unused-variables branch May 12, 2020 14:26
codebytere pushed a commit that referenced this pull request May 16, 2020
@rickyes @codebytere
src: delete unused variables to resolve compile time print warning
c9c16c0 
PR-URL: #33358
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@rickyes @codebytere
src: delete unused variables to resolve compile time print warning
82c43d1 
PR-URL: #33358
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rickyes @nodejs-github-bot @addaleax @richardlau @jasnell @cjihrig @devnexen