Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-net-throttle #33329

Merged
merged 1 commit into from
May 11, 2020
Merged

test: fix test-net-throttle #33329

merged 1 commit into from
May 11, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented May 9, 2020

Repeat writes until data is queued in memory, rather than assuming that
it will happen by a certain point.

Fixes: #33135

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 9, 2020
@Trott
Copy link
Member Author

Trott commented May 9, 2020

Relevant CI run is: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14181/

Pummel tests otherwise don't get run in CI, so only the linter and the above job are relevant.

@Trott
Copy link
Member Author

Trott commented May 9, 2020

The test passed in CI. First time in something like two weeks!

@Trott Trott mentioned this pull request May 9, 2020
Closed
@Trott Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label May 9, 2020
lpinca
lpinca approved these changes May 9, 2020
View reviewed changes
test/pummel/test-net-throttle.js Outdated Show resolved Hide resolved
@Trott
Copy link
Member Author

Trott commented May 9, 2020

Re-running relevant CI post-fixup commit: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14184/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 10, 2020
@Trott Trott mentioned this pull request May 10, 2020
Closed
4 tasks
@Trott
Copy link
Member Author

Trott commented May 10, 2020

This is basically the only thing that has kept node-daily-master from being green many days now.

Fast-track? 👍 here to approve if you're a Collaborator.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label May 10, 2020
@Trott
test: fix test-net-throttle
5ded044 
Repeat writes until data is queued in memory, rather than assuming that
it will happen by a certain point.

Fixes: nodejs#33135

PR-URL: nodejs#33329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@Trott
Copy link
Member Author

Trott commented May 11, 2020

Landed in 5ded044

@Trott Trott merged commit 5ded044 into nodejs:master May 11, 2020
codebytere pushed a commit that referenced this pull request May 15, 2020
@Trott @codebytere
test: fix test-net-throttle
5b2cd44 
Repeat writes until data is queued in memory, rather than assuming that
it will happen by a certain point.

Fixes: #33135

PR-URL: #33329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@Trott @codebytere
test: fix test-net-throttle
c459832 
Repeat writes until data is queued in memory, rather than assuming that
it will happen by a certain point.

Fixes: #33135

PR-URL: #33329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Merged
@Trott Trott deleted the fix-test-net-throttle branch April 14, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky test-net-throttle on daily master
4 participants
@Trott @lpinca @juanarbol @nodejs-github-bot