Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update to ICU 67.1 #33324

Closed
wants to merge 2 commits into from
Closed

deps: update to ICU 67.1 #33324

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented May 9, 2020 •
edited
Loading

@targos targos requested review from srl295 and ryzokuken May 9, 2020 11:43
ryzokuken
ryzokuken approved these changes May 9, 2020
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@richardlau
Copy link
Member

tools/icu/current_ver.dep should be updated: https://github.com/nodejs/node/blob/master/doc/guides/maintaining-icu.md#how-to-upgrade-icu

@targos
Copy link
Member Author

targos commented May 9, 2020

Am I supposed to compute the md5 myself?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31253/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 9, 2020
srl295
srl295 approved these changes May 9, 2020
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta LGTM, code RSLGTM

@srl295
Copy link
Member

srl295 commented May 9, 2020 •
edited
Loading

in progress https://www.npmjs.com/package/icu4c-data

@srl295
Copy link
Member

srl295 commented May 9, 2020

in progress https://www.npmjs.com/package/icu4c-data

I'm getting timeouts…again… trying to publish to npm. So it's not quite there.

@codebytere
Copy link
Member

@targos does this close nodejs/Release#576? It was assigned to me per the last release meeting so i want to make sure i'm not duplicating work.

@targos
Copy link
Member Author

targos commented May 11, 2020

@codebytere I don't know. I asked the same question to @srl295 (#33337 (comment)) 15 minutes ago 😄

@srl295
Copy link
Member

srl295 commented May 11, 2020 •
edited
Loading

@targos does this close nodejs/Release#576? It was assigned to me per the last release meeting so i want to make sure i'm not duplicating work.

Ugh. did not see this, I could have incorporated this into the data.

No, that bug shows as fixed in 68 not 67.

targos added a commit that referenced this pull request May 12, 2020
@targos
deps: update to ICU 67.1
cfec30f 
Refs: https://github.com/unicode-org/icu/releases/tag/release-67-1

PR-URL: #33324
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
@targos
Copy link
Member Author

targos commented May 12, 2020

Landed in cfec30f

@targos targos closed this May 12, 2020
@targos targos deleted the icu-67.1 branch May 12, 2020 07:58
@targos targos added backport-open-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 12, 2020
@srl295 srl295 mentioned this pull request May 12, 2020
Closed
codebytere pushed a commit that referenced this pull request May 16, 2020
@targos @codebytere
deps: update to ICU 67.1
331f0b3 
Refs: https://github.com/unicode-org/icu/releases/tag/release-67-1

PR-URL: #33324
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@srl295 srl295 srl295 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @richardlau @nodejs-github-bot @srl295 @codebytere @ryzokuken @addaleax @BridgeAR