[v12.x] Disable headers timeout #33307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thank you for your contribution, would you mind adding a test for this? |
|
Good point, I forgot. Will add it now! |
|
For some reason "now" became "3 days". :) |
|
I'm not 100% sure about this, but I think this needs to be opened against v12.x-staging rather than v12.x. (Someone else, please confirm!) @nodejs/releasers |
That's correct |
|
/cc @nodejs/http |
BridgeAR
approved these changes
May 23, 2020
|
@targos should this still be included in the next v12 release? @nodejs/http @nodejs/http2 @nodejs/streams PTAL |
|
I hope it would be included. |
targos
pushed a commit
that referenced
this pull request
May 25, 2020
PR-URL: #33307 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in ebd9090. Thanks @ShogunPanda |
richardlau
pushed a commit
that referenced
this pull request
Jul 2, 2020
PR-URL: #33307 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
headersTimeoutto 0 does not disable the checks as expected but rather makes any request fail immediately.This PR fixes the problem. This should also be backported to 10.x.
Node 13 and 14/master are fine since headersTimeout live now in HTTPParser which correctly checks for the value being greater than 0.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes