Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix md issue in src/README.md #33224

Closed
wants to merge 1 commit into from
Closed

doc: fix md issue in src/README.md #33224

wants to merge 1 commit into from

Conversation

juanarbol
Copy link
Member

Checklist

There is an issue parsing the md

Screenshot from 2020-05-03 18-45-13

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 3, 2020
@juanarbol juanarbol added the doc Issues and PRs related to the documentations. label May 3, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 4, 2020
addaleax pushed a commit that referenced this pull request May 7, 2020
@juanarbol @addaleax
doc: fix md issue in src/README.md
3f1e65d 
PR-URL: #33224
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@addaleax
Copy link
Member

addaleax commented May 7, 2020

Landed in 3f1e65d

@addaleax addaleax closed this May 7, 2020
codebytere pushed a commit that referenced this pull request May 11, 2020
@juanarbol @codebytere
doc: fix md issue in src/README.md
c6a8cd0 
PR-URL: #33224
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
@codebytere
Copy link
Member

Blocked on #32538

@juanarbol juanarbol deleted the juanarbol/internals-readme branch January 19, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHeer MrHeer MrHeer approved these changes

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@juanarbol @addaleax @codebytere @Trott @lpinca @BridgeAR @trivikr @MrHeer @nodejs-github-bot