test: move test-process-title to sequential

[addaleax]

This test can fail when run in parallel with test-process-title-cli,
which also sets the process title, which is global state on Windows.

Example failure (note that foo does not appear in test-process-title
but in test-process-title-cli):

not ok 1727 parallel/test-process-title
  ---
  duration_ms: 0.156
  severity: fail
  exitcode: 1
  stack: |-
    assert.js:103
      throw new AssertionError(obj);
      ^

    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    + actual - expected

    + 'foo'
    - 'd:\\a\\node\\node\\out\\Release\\node.exe'
        at Object.<anonymous> (d:\a\node\node\test\parallel\test-process-title.js:22:1)
        at Module._compile (internal/modules/cjs/loader.js:1176:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10)
        at Module.load (internal/modules/cjs/loader.js:1040:32)
        at Function.Module._load (internal/modules/cjs/loader.js:929:14)
        at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
        at internal/main/run_main_module.js:17:47 {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: 'foo',
      expected: 'd:\\a\\node\\node\\out\\Release\\node.exe',
      operator: 'strictEqual'
    }
  ...

(from https://github.com/nodejs/node/runs/628144750?check_suite_focus=true)

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[addaleax]

👍 to fast-track? Not sure how flaky this is exactly but this should be very low-risk.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31102/

[richardlau]

This test can fail when run in parallel with test-process-title-cli,
which also sets the process title, which is global state on Windows.

Should we move that too?

[addaleax]

@richardlau I think moving one should be sufficient.

There are also other tests that set the process title, but I think this one is affected specifically because it spawns a new child process to get the current process title (i.e. there is a race condition window between the process.title = process.execPath line and the child process reading process.title). I don’t think the other tests are affected in the same way because they only access process.title inside the a single process, but I guess somebody with more Windows experience would have to confirm that.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31103/

[puzpuzpuz]

Landed in ab41b98