stream: consistent punctuation #32934
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
lpinca
approved these changes
Apr 20, 2020
benjamingr
approved these changes
Apr 20, 2020
Flarna
approved these changes
Apr 20, 2020
ronag
added
the
author ready
Collaborator
trivikr
approved these changes
Apr 20, 2020
BridgeAR
approved these changes
Apr 20, 2020
juanarbol
approved these changes
Apr 20, 2020
Collaborator
Cleanup comments to use consistent punctuation.
Member
Author
|
rebased to fix conflicts |
ronag
force-pushed
the
stream-punctuation
branch
from
f7fde21 to
7134775
Compare
Collaborator
Collaborator
Collaborator
MrHeer
approved these changes
Apr 24, 2020
addaleax
approved these changes
Apr 24, 2020
Collaborator
Member
Author
|
Landed in 802edb1 |
ronag
added a commit
that referenced
this pull request
Apr 24, 2020
Cleanup comments to use consistent punctuation. PR-URL: #32934 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
Cleanup comments to use consistent punctuation. PR-URL: #32934 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
Cleanup comments to use consistent punctuation. PR-URL: #32934 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup comments to use consistent punctuation.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes