[v14] build: remove .git folders when testing V8 #32889
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `make test-v8` V8's `gclient sync` converts folders under `deps/v8/third_party` into git repositories. Unfortunately the files that were checked in under `deps/v8/third_party/zlib` have been modified from the upstream Chromium repository (some files have been deleted and there are whitespace differences in some of the files that were kept) so whenever the Node.js source tree is hard reset/checked out `gclient sync` notices there are unstaged changes as the files in the Node.js source tree do not match those of the upstream Chromium third party zlib commit. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: nodejs#32877 Refs: nodejs/build#2256 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs-github-bot
added
build
Contributor
|
It seems like this already landed (earlier today) in f2c22db Should this be closed? |
Contributor
Author
|
Yes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passescc @nodejs/releasers