Skip to content

[v12.x] module: path-only CJS exports extension searching #32883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[v12.x] module: path-only CJS exports extension searching #32883

wants to merge 2 commits into from

Conversation

@MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Apr 16, 2020

PR-URL: #32351
Reviewed-By: Geoffrey Booth webmaster@geoffreybooth.com
Reviewed-By: Bradley Farias bradley.meck@gmail.com
Reviewed-By: Jan Krems jan.krems@gmail.com
Reviewed-By: Myles Borins myles.borins@gmail.com

@guybedford @MylesBorins
module: path-only CJS exports extension searching
98dec2c 
PR-URL: nodejs#32351
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins changed the title module: path-only CJS exports extension searching [v12.x] module: path-only CJS exports extension searching Apr 16, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 16, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30788/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 16, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30791/

MylesBorins pushed a commit that referenced this pull request Apr 17, 2020
@guybedford @MylesBorins
module: path-only CJS exports extension searching
717f9c5 
Backport-PR-URL: #32883
PR-URL: #32351
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Apr 17, 2020

landed in 717f9c5

This was referenced Aug 31, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 12, 2021
Open
Open
Open
Open
Open
Open
Open
@137717unity 137717unity mentioned this pull request Mar 22, 2024
Open
@baby636 baby636 mentioned this pull request Mar 22, 2024
Open
@kissofire kissofire mentioned this pull request Mar 22, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Mar 22, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Mar 22, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Mar 23, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 13, 2024
Open
@molllyn1 molllyn1 mentioned this pull request May 13, 2024
Open
@ron-a20 ron-a20 mentioned this pull request May 13, 2024
Open
@kissofire kissofire mentioned this pull request May 13, 2024
Open
@137717unity 137717unity mentioned this pull request May 14, 2024
Open
@baby636 baby636 mentioned this pull request May 14, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request May 14, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 15, 2024
Open
@kissofire kissofire mentioned this pull request May 20, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 21, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request May 21, 2024
Open
@137717unity 137717unity mentioned this pull request May 21, 2024
Open
@molllyn1 molllyn1 mentioned this pull request May 21, 2024
Open
@ron-a20 ron-a20 mentioned this pull request May 22, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 9, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Oct 9, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Oct 11, 2024
Open
@137717unity 137717unity mentioned this pull request Oct 13, 2024
Open
@kissofire kissofire mentioned this pull request Oct 13, 2024
Open
@137717unity 137717unity mentioned this pull request Oct 20, 2024
Open
@kissofire kissofire mentioned this pull request Oct 20, 2024
Open
@opekeye opekeye mentioned this pull request Oct 20, 2024
Open
@molllyn1 molllyn1 mentioned this pull request Oct 22, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hybrist hybrist hybrist approved these changes

@guybedford guybedford guybedford approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MylesBorins @nodejs-github-bot @hybrist @guybedford