src: use basename(argv0) for --trace-uncaught suggestion #32798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
3 tasks
devnexen
approved these changes
Apr 12, 2020
richardlau
reviewed
Apr 12, 2020
richardlau
approved these changes
Apr 12, 2020
addaleax
added
the
author ready
|
CI: https://ci.nodejs.org/job/node-test-pull-request/30690/ (:white_check_mark:) |
bnoordhuis
reviewed
Apr 13, 2020
addaleax
added a commit
that referenced
this pull request
Apr 15, 2020
Refs: #32797 (comment) PR-URL: #32798 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Landed in e0a7fd7 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2020
Refs: #32797 (comment) PR-URL: #32798 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos
added
baking-for-lts
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
Refs: #32797 (comment) PR-URL: #32798 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
Refs: #32797 (comment) PR-URL: #32798 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 18, 2020
targos
removed
the
baking-for-lts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #32797 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes