Skip to content

lib: remove unnecesary else block#32644

Closed
ddazal wants to merge 1 commit intonodejs:masterfrom
ddazal:ddazal/child-process-serialization-early-return
Closed

lib: remove unnecesary else block#32644
ddazal wants to merge 1 commit intonodejs:masterfrom
ddazal:ddazal/child-process-serialization-early-return

Conversation

@ddazal
Copy link
Contributor

@ddazal ddazal commented Apr 3, 2020

The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ddazal
lib: remove unnecesary else block
bc549d0 
The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary
@nodejs-github-bot nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label Apr 3, 2020
@lpinca lpinca mentioned this pull request Apr 5, 2020
Closed
2 tasks
@juanarbol juanarbol added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 18, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 18, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30836/

juanarbol pushed a commit that referenced this pull request Apr 18, 2020
@ddazal @juanarbol
lib: remove unnecesary else block
83f7bb4 
The if statement inside the _writeHostObject function
returns an expression which makes the else block unnecessary.

PR-URL: #32644
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@juanarbol
Copy link
Member

juanarbol commented Apr 18, 2020

Nice catch, hope to see more of your contributions 💚

Landed in 83f7bb4 🎉

@juanarbol juanarbol closed this Apr 18, 2020
@ddazal ddazal deleted the ddazal/child-process-serialization-early-return branch April 18, 2020 22:05
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@ddazal @BethGriggs
lib: remove unnecesary else block
b957895 
The if statement inside the _writeHostObject function
returns an expression which makes the else block unnecessary.

PR-URL: #32644
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@ddazal @BridgeAR
lib: remove unnecesary else block
8a85afa 
The if statement inside the _writeHostObject function
returns an expression which makes the else block unnecessary.

PR-URL: #32644
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
@ddazal @targos
lib: remove unnecesary else block
84571ce 
The if statement inside the _writeHostObject function
returns an expression which makes the else block unnecessary.

PR-URL: #32644
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@targos targos mentioned this pull request May 2, 2020
Merged
lpinca added a commit to lpinca/node that referenced this pull request May 15, 2020
@lpinca
tools: enable no-else-return lint rule
af70a1c 
Refs: nodejs#32644
Refs: nodejs#32662
lpinca added a commit that referenced this pull request May 16, 2020
@lpinca
tools: enable no-else-return lint rule
b533fb3 
Refs: #32644
Refs: #32662

PR-URL: #32667
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request May 16, 2020
@lpinca @codebytere
tools: enable no-else-return lint rule
9119344 
Refs: #32644
Refs: #32662

PR-URL: #32667
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@lpinca lpinca mentioned this pull request Jul 9, 2020
Closed
4 tasks
lpinca added a commit to lpinca/node that referenced this pull request Jul 9, 2020
@lpinca
tools: enable no-else-return lint rule
441e6d9 
Refs: nodejs#32644
Refs: nodejs#32662

PR-URL: nodejs#32667
Backport-PR-URL: nodejs#34275
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 13, 2020
@lpinca @codebytere
tools: enable no-else-return lint rule
a131c72 
Refs: #32644
Refs: #32662

PR-URL: #32667
Backport-PR-URL: #34275
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@lpinca @codebytere
tools: enable no-else-return lint rule
248f9af 
Refs: #32644
Refs: #32662

PR-URL: #32667
Backport-PR-URL: #34275
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@juanarbol juanarbol juanarbol approved these changes

+1 more reviewer

@awibox awibox awibox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ddazal @nodejs-github-bot @juanarbol @jasnell @addaleax @lpinca @awibox @BridgeAR