doc: improve Buffer documentation #32086
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various improvements to the Buffer docs.
nodejs-github-bot
added
buffer
jasnell
approved these changes
Mar 4, 2020
Member
Author
|
@jasnell I’ve updated this based on feedback I’ve received in private, feel free to take another look :) |
addaleax
force-pushed
the
buffer-doc-rewrite
branch
from
cb995aa to
8cc28ab
Compare
Member
Author
|
@nodejs/documentation |
Member
|
Still LGTM |
addaleax
added
the
author ready
Member
Author
|
Landed in c41e360 |
addaleax
added a commit
that referenced
this pull request
Mar 11, 2020
Various improvements to the Buffer docs. PR-URL: #32086 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 11, 2020
Various improvements to the Buffer docs. PR-URL: #32086 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Various improvements to the Buffer docs. PR-URL: #32086 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to the Buffer docs.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes