n-api: define release 6 #32058

gabrielschulhof · 2020-03-03T06:39:37Z

Mark all N-APIs that have been added since version 5 as stable.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

legendecas

LGTM % napi_create_bigint_uint64 is missing in the changed docs.

nodejs-github-bot · 2020-03-05T22:55:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29573/

nodejs-github-bot · 2020-03-06T00:44:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29578/

nodejs-github-bot · 2020-03-06T01:10:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29580/

legendecas · 2020-03-06T01:49:00Z

Maybe I'm not been clear about the issue. https://github.com/nodejs/node/blob/master/doc/api/n-api.md#napi_create_bigint_uint64 there is a doc on napi_create_bigint_uint64 but the stability and version status have not been changed in the PR.

nodejs-github-bot · 2020-03-06T01:51:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29582/

gabrielschulhof · 2020-03-06T01:53:02Z

@legendecas fixed.

nodejs-github-bot · 2020-03-06T01:54:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29583/

doc/api/n-api.md

nodejs-github-bot · 2020-03-06T06:01:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29585/

gabrielschulhof · 2020-03-06T15:55:09Z

Rebased.

nodejs-github-bot · 2020-03-06T15:57:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29590/

mhdawson · 2020-03-06T18:52:25Z

src/js_native_api.h

@@ -531,7 +532,7 @@ NAPI_EXTERN napi_status napi_detach_arraybuffer(napi_env env,
 NAPI_EXTERN napi_status napi_is_detached_arraybuffer(napi_env env,
                                                     napi_value value,
                                                     bool* result);
-#endif  // NAPI_EXPERIMENTAL
+#endif  // NAPI_VERSION >= 6


I don't see napi_is_detached_arraybuffer, napi_detach_arraybuffer in the 10.x staging branch and a quick look at PR's I don't see anything labelled with napi that would add them.

Did we intend to add them to NAPI_VERSION 6? I'm thinking no (unless I've missed the PR where they will be added) since we were waiting for other PR to land in 10.x first.

mhdawson

Requesting changes until my question is resolved

gabrielschulhof · 2020-03-07T04:39:36Z

@mhdawson good point. Looks like we need to do some unifying of the release lines first. As it stands, we have the followings:

v12.x has
- bigint
- instance_data
- detach
v10.x has
- bigint
- instance_data
- get_all_property_names

So we need to backport get_all_property_names to v12.x, and detach to v10.x.

gabrielschulhof · 2020-03-07T07:28:50Z

detach is unavailable in 10.

gabrielschulhof · 2020-03-07T07:37:34Z

get_all_properties applies cleanly to v12.x-staging.

Mark all N-APIs that have been added since version 5 as stable. Fixes: nodejs/abi-stable-node#393 Co-Authored-By: legendecas <legendecas@gmail.com> Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>

gabrielschulhof · 2020-03-07T08:19:00Z

@mhdawson I removed the portion of the PR that marks the detach-related N-APIs as stable.

Notable changes: * async_hooks: - add sync enterWith to ALS (Stephen Belanger) #31945 * cli: - allow --jitless V8 flag in NODE\_OPTIONS (Andrew Neitsch) #32100 * fs: - return first folder made by mkdir recursive (Benjamin Coe) #31530 * n-api: - define release 6 (Gabriel Schulhof) #32058 * src: - create a getter for kernel version (Juan José Arboleda) #31732 * wasi: - add returnOnExit option (Colin Ihrig) #32101 PR-URL: #32185

mhdawson · 2020-03-12T18:36:57Z

@myles I believe so.

gabrielschulhof · 2020-03-14T07:58:22Z

@mhdawson @MylesBorins N-API 5 was not semver-minor.

gabrielschulhof · 2020-03-14T07:59:11Z

... at least it was not marked as such in the PR.

MylesBorins · 2020-03-14T22:29:10Z

In theory it should have been as well perhaps? Might be good for us to take a stance on this and document it.

…

On Sat, Mar 14, 2020, 3:59 AM Gabriel Schulhof ***@***.***> wrote: ... at least it was not marked as such in the PR. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32058 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADZYV2JZUCL2QDSYLT2H63RHM2NZANCNFSM4LADQ3GQ> .

Mark all N-APIs that have been added since version 5 as stable. PR-URL: nodejs#32058 Fixes: nodejs/abi-stable-node#393 Co-Authored-By: legendecas <legendecas@gmail.com> Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Mark all N-APIs that have been added since version 5 as stable. PR-URL: #32058 Backport-PR-URL: #32488 Fixes: nodejs/abi-stable-node#393 Co-Authored-By: legendecas <legendecas@gmail.com> Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Notable changes: - buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - build: macOS package notarization (Rod Vagg) [#31459](#31459) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](#32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - define release 6 [#32058](#32058) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](#26226) PR-URL: #31984

macOS package notarization and a change in builder configuration The macOS binaries for this release, and future 10.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing .pkg files on macOS 10.15 and later. Previous builds of Node.js 10.x were compiled on macOS 10.7 (Lion). As binaries are still being compiled to support a minimum of macOS 10.7 (Lion) we do not anticipate this having a negative impact on Node.js 10.x users with older versions of macOS. Notable changes: - buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - build: macOS package notarization (Rod Vagg) [#31459](#31459) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](#32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - define release 6 [#32058](#32058) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](#26226) PR-URL: #31984

macOS package notarization and a change in builder configuration The macOS binaries for this release, and future 10.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing .pkg files on macOS 10.15 and later. Previous builds of Node.js 10.x were compiled on macOS 10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion). As binaries are still being compiled to support a minimum of macOS 10.7 (Lion) we do not anticipate this having a negative impact on Node.js 10.x users with older versions of macOS. Notable changes: - buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - build: macOS package notarization (Rod Vagg) [#31459](#31459) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](#32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - define release 6 [#32058](#32058) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](#26226) PR-URL: #31984

Mark all N-APIs that have been added since version 5 as stable. Backport-PR-URL: nodejs#32482 PR-URL: nodejs#32058 Fixes: nodejs/abi-stable-node#393 Co-Authored-By: legendecas <legendecas@gmail.com> Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Mark all N-APIs that have been added since version 5 as stable. Backport-PR-URL: #32482 PR-URL: #32058 Fixes: nodejs/abi-stable-node#393 Co-Authored-By: legendecas <legendecas@gmail.com> Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 3, 2020

gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Mar 3, 2020

gabrielschulhof force-pushed the n-api-6 branch 2 times, most recently from 5da4811 to b094860 Compare March 3, 2020 07:24

bnoordhuis approved these changes Mar 3, 2020

View reviewed changes

cjihrig approved these changes Mar 3, 2020

View reviewed changes

legendecas approved these changes Mar 5, 2020

View reviewed changes

gabrielschulhof mentioned this pull request Mar 5, 2020

Document napi_create_bigint_uint64 #32112

Closed

gabrielschulhof force-pushed the n-api-6 branch from b094860 to d389aab Compare March 6, 2020 01:52

legendecas reviewed Mar 6, 2020

View reviewed changes

doc/api/n-api.md Show resolved Hide resolved

gabrielschulhof force-pushed the n-api-6 branch from 34b04ac to 133a492 Compare March 6, 2020 15:54

mhdawson reviewed Mar 6, 2020

View reviewed changes

mhdawson requested changes Mar 6, 2020

View reviewed changes

gabrielschulhof mentioned this pull request Mar 7, 2020

n-api: add napi_get_all_property_names #30006

Closed

3 tasks

n-api: define release 6

9f588c1

Mark all N-APIs that have been added since version 5 as stable. Fixes: nodejs/abi-stable-node#393 Co-Authored-By: legendecas <legendecas@gmail.com> Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>

gabrielschulhof force-pushed the n-api-6 branch from 133a492 to 9f588c1 Compare March 7, 2020 08:18

mhdawson added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 12, 2020

BethGriggs mentioned this pull request Apr 6, 2020

v10.20.0 proposal #31984

Merged

targos added backported-to-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 25, 2020

targos mentioned this pull request May 2, 2020

v12.17.0 release proposal #33197

Merged

Uh oh!

n-api: define release 6 #32058

n-api: define release 6 #32058

Uh oh!

Conversation

gabrielschulhof commented Mar 3, 2020

Checklist

Uh oh!

legendecas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 5, 2020

Uh oh!

nodejs-github-bot commented Mar 6, 2020

Uh oh!

nodejs-github-bot commented Mar 6, 2020

Uh oh!

legendecas commented Mar 6, 2020

Uh oh!

nodejs-github-bot commented Mar 6, 2020

Uh oh!

gabrielschulhof commented Mar 6, 2020

Uh oh!

nodejs-github-bot commented Mar 6, 2020

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 6, 2020

Uh oh!

gabrielschulhof commented Mar 6, 2020

Uh oh!

nodejs-github-bot commented Mar 6, 2020

Uh oh!

mhdawson Mar 6, 2020

Choose a reason for hiding this comment

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

gabrielschulhof commented Mar 7, 2020

Uh oh!

gabrielschulhof commented Mar 7, 2020

Uh oh!

gabrielschulhof commented Mar 7, 2020

Uh oh!

gabrielschulhof commented Mar 7, 2020

Uh oh!

mhdawson commented Mar 12, 2020

Uh oh!

gabrielschulhof commented Mar 14, 2020

Uh oh!

gabrielschulhof commented Mar 14, 2020

Uh oh!

MylesBorins commented Mar 14, 2020 via email

Uh oh!

Uh oh!

legendecas left a comment •

edited

Loading