build: make icu download path customisable #3200
Merged
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm
I tried to keep the download path isolated (but didn't make it
configurable), looks like that succeeded.
|
| @@ -833,11 +839,14 @@ def configure_intl(o): | |||
| ] | |||
| def icu_download(path): | |||
| # download ICU, if needed | |||
| if not os.path.exists(options.download_path): | |||
There was a problem hiding this comment.
Something of an anti-pattern, this. Whether the path exists doesn't say anything about it being accessible.
There was a problem hiding this comment.
use os.access instead?
|
lgtm! |
|
LGTM |
jbergstroem
force-pushed
the
feature/icu-download-path
branch
from
6c94583 to
92c7a6f
Compare
|
@bnoordhuis I slightly tweaked the error message and now check for writability through |
|
Better, I suppose. LGTM. |
This makes it easier to store icu tarballs outside of the node.js directory which is useful in our CI where git directories are scrubbed between runs. PR-URL: nodejs#3200 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
jbergstroem
force-pushed
the
feature/icu-download-path
branch
from
92c7a6f to
a214905
Compare
|
Just for the record: |
jbergstroem
added a commit
that referenced
this pull request
Oct 8, 2015
This makes it easier to store icu tarballs outside of the node.js directory which is useful in our CI where git directories are scrubbed between runs. PR-URL: #3200 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
|
landed in v4.x-staging in 9136359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to store icu tarballs outside of the node.js directory which is useful in our CI where git directories are scrubbed between runs.
/R=@srl295, @rvagg