Skip to content

test: add GC test for disabled AsyncLocalStorage #31995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: add GC test for disabled AsyncLocalStorage #31995

wants to merge 1 commit into from

Conversation

@puzpuzpuz
Copy link
Member

@puzpuzpuz puzpuzpuz commented Feb 28, 2020

Adds a GC test for AsyncLocalStorage to verify behavior described in the docs.

cc @vdeturckheim @Qard @Flarna

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Feb 28, 2020
@addaleax
Copy link
Member

addaleax commented Feb 28, 2020

Fast-track? It adds a relatively straightforward new test.

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 28, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 28, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29427/

@puzpuzpuz
Copy link
Member Author

puzpuzpuz commented Feb 28, 2020

Looks like tests are flaky. As far as I can see, failed tests are not related with this PR.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 1, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29469/

@puzpuzpuz
Copy link
Member Author

puzpuzpuz commented Mar 2, 2020

Another flaky CI run 😢. Could someone re-run it?

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 2, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29477/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 2, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29481/

@puzpuzpuz puzpuzpuz force-pushed the async-storage-gcable-test branch from 8756024 to e4f1c18 Compare March 2, 2020 14:12
@puzpuzpuz
Copy link
Member Author

puzpuzpuz commented Mar 2, 2020

I have rebased over the latest master. Maybe those flaky tests are fixed and it would help CI build to pass.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 2, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29484/

@puzpuzpuz
Copy link
Member Author

puzpuzpuz commented Mar 2, 2020

Another flaky CI run here.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 2, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29493/

@puzpuzpuz
Copy link
Member Author

puzpuzpuz commented Mar 2, 2020

Looks like this one is ready to land.

mhdawson
mhdawson approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Mar 2, 2020

Landing now

mhdawson pushed a commit that referenced this pull request Mar 2, 2020
@puzpuzpuz @mhdawson
test: add GC test for disabled AsyncLocalStorage
96e70c4 
PR-URL: #31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson
Copy link
Member

mhdawson commented Mar 2, 2020

Landed as 96e70c4

@mhdawson mhdawson closed this Mar 2, 2020
@puzpuzpuz puzpuzpuz deleted the async-storage-gcable-test branch March 3, 2020 08:34
MylesBorins pushed a commit that referenced this pull request Mar 4, 2020
@puzpuzpuz @MylesBorins
test: add GC test for disabled AsyncLocalStorage
1539928 
PR-URL: #31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 4, 2020
Merged
@codebytere
Copy link
Member

codebytere commented Mar 16, 2020

Blocked on #26540.

@puzpuzpuz puzpuzpuz mentioned this pull request Mar 17, 2020
Closed
4 tasks
@puzpuzpuz
Copy link
Member Author

puzpuzpuz commented Mar 17, 2020

v12 backport: #32318

puzpuzpuz added a commit to puzpuzpuz/node that referenced this pull request Apr 14, 2020
@puzpuzpuz
test: add GC test for disabled AsyncLocalStorage
ecc5935 
PR-URL: nodejs#31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@puzpuzpuz @targos
test: add GC test for disabled AsyncLocalStorage
c759d65 
PR-URL: nodejs#31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@puzpuzpuz @targos
test: add GC test for disabled AsyncLocalStorage
52a1154 
PR-URL: #31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qard Qard Qard approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@mhdawson mhdawson mhdawson approved these changes

@Flarna Flarna Flarna approved these changes

+1 more reviewer

@vdeturckheim vdeturckheim vdeturckheim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.