build: create smaller build artifacts #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbergstroem
force-pushed
the
shrink_build_artifacts
branch
from
f4930c7
to
197d985
Compare
| find $(TARNAME)/ -type l | xargs rm # annoying on windows | ||
| tar -cf $(TARNAME).tar $(TARNAME) | ||
| rm -rf $(TARNAME) | ||
| gzip -f -9 $(TARNAME).tar | ||
| gzip -k -f -9 $(TARNAME).tar |
There was a problem hiding this comment.
-k isn't very portable, it's missing on older versions of gzip and we like to make some of these assets on older systems. Perhaps gzip -c -f -9 $(TARNAME).tar > $(TARNAME).tar.gz
|
@jbergstroem would you mind adding this to the |
|
@rvagg Thanks for the review; I'll revise. |
check if xz exists on the host system and use if available, which makes xz-tarballs available for distribution. also remove deps/zlib/contrib since it's not in use -- shaves additional size from the tarballs. also, slightly modify the .gitignore file to ignore these new archives.
jbergstroem
force-pushed
the
shrink_build_artifacts
branch
from
197d985
to
e3a3bff
Compare
|
@rvagg BINARYNAME now also gets xz-treatment. Edit: remove additional questions since they belong in another issue. |
rvagg
pushed a commit
that referenced
this pull request
Jan 13, 2015
check if xz exists on the host system and use if available, which makes xz-tarballs available for distribution. also remove deps/zlib/contrib since it's not in use -- shaves additional size from the tarballs. also, slightly modify the .gitignore file to ignore these new archives. PR-URL: #319 Reviewed-By: Rod Vagg <rod@vagg.org>
|
thanks @jbergstroem, landed in 17217c3 and I'll be trying this on our next nightly (soon) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check if xz exists on the host system and use if available, which makes
xz-tarballs available for distribution. also remove deps/zlib/contrib
since it's not in use -- shaves additional size from the tarballs.
also, slightly modify the .gitignore file to ignore these new archives.
Refs #301.