dgram: make UDPWrap more reusable #31871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
addaleax
approved these changes
Feb 19, 2020
mscdex
reviewed
Feb 19, 2020
bnoordhuis
reviewed
Feb 20, 2020
|
@addaleax ... given that you wrote the original change here, do you have thoughts on the suggestions from @mscdex and @bnoordhuis ? |
|
@jasnell Feel free to address Ben’s comments (or if you want, I can do that later this evening) |
|
Waiting for #31960 to land then will rebase this and update it to incorporate those changes. |
jasnell
force-pushed
the
reusable-udpwrap
branch
from
744a2ce
to
34721a8
Compare
|
Rebased now that #31960 landed. @bnoordhuis and @addaleax, please take another look |
addaleax
reviewed
Mar 2, 2020
addaleax
approved these changes
Mar 2, 2020
jasnell
added
the
author ready
Allow using the handle more directly for I/O in other parts of the codebase. Originally landed in the QUIC repo Original review metadata: ``` PR-URL: nodejs/quic#165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> ``` Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
reusable-udpwrap
branch
from
34721a8
to
347ea10
Compare
bnoordhuis
approved these changes
Mar 3, 2020
jasnell
pushed a commit
that referenced
this pull request
Mar 3, 2020
Allow using the handle more directly for I/O in other parts of the codebase. Originally landed in the QUIC repo Original review metadata: ``` PR-URL: nodejs/quic#165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> ``` Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31871 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in 43b7142 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 4, 2020
Allow using the handle more directly for I/O in other parts of the codebase. Originally landed in the QUIC repo Original review metadata: ``` PR-URL: nodejs/quic#165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> ``` Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31871 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
|
Depends on #31960 to land on v12.x |
targos
removed
the
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Allow using the handle more directly for I/O in other parts of the codebase. Originally landed in the QUIC repo Original review metadata: ``` PR-URL: nodejs/quic#165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> ``` Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#31871 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Allow using the handle more directly for I/O in other parts of the codebase. Originally landed in the QUIC repo Original review metadata: ``` PR-URL: nodejs/quic#165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> ``` Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31871 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authored by @addaleax and originally landed in the QUIC repo. Separating out from the QUIC PR. While this does not have any QUIC specific bits, QUIC would be the only current use of it so it would likely be best to land this PR in conjunction with the QUIC PR. Separating out only to make it easier to review.
Allow using the handle more directly for I/O in other parts of the codebase.
Original review metadata:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes