Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: Check for overflow when resizing AliasedBufferBase #31740

Closed
wants to merge 3 commits into from
Closed

src: Check for overflow when resizing AliasedBufferBase #31740

wants to merge 3 commits into from

Commits on Feb 14, 2020

  1. src: Check for overflow when extending AliasedBufferBase 

    When resizing an aliased_buffer check if the new size will overflow.
    @amdoku
    amdoku committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    fac0992 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2020

  1. src: Add aliased-buffer-overflow abort test 

    Added native extension similar to
test/addons/stringbytes-external-exceeded-max.
Added an abort test to regression test the non overflow behaviour.
    @amdoku
    amdoku committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    2f23066 View commit details
    Browse the repository at this point in the history

  2. src: Add test/abort build tasks 

    The Aliased*Array overflow check test introduced a dependency to a
compiled artifact. Add this artifact to the build process in a
similar fashion as test/addons and test/js-native-api do.
    @amdoku
    amdoku committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    0382006 View commit details
    Browse the repository at this point in the history