Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add directions to mark a release line as lts #31724

Closed
wants to merge 1 commit into from
Closed

add directions to mark a release line as lts #31724

wants to merge 1 commit into from

Conversation

danielleadams
Copy link
Contributor

Adds the LTS release directions (removed from here: nodejs/Release#531). Fixes: nodejs/Release#530.

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 10, 2020
docs: add directions to mark a release line as lts
2d6e6df 
Moves directions for LTS release from the Release repo to Node docs.

Fixes: nodejs/Release#530
@danielleadams danielleadams mentioned this pull request Feb 10, 2020
Merged
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 11, 2020
MylesBorins
MylesBorins approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMT

@MylesBorins
Copy link
Contributor

Can we fast track this? It is moving existing documentation.

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 12, 2020
@addaleax
Copy link
Member

Landed in e5e011d 🎉

@addaleax addaleax closed this Feb 13, 2020
addaleax pushed a commit that referenced this pull request Feb 13, 2020
@addaleax
doc: add directions to mark a release line as lts
e5e011d 
Moves directions for LTS release from the Release repo to Node docs.

Fixes: nodejs/Release#530
PR-URL: #31724
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit to nodejs/Release that referenced this pull request Feb 14, 2020
@danielleadams
doc: remove section for marking release LTS (#531)
0a2340d 
This documentation was moved to Releases.md in nodejs/node#31724

Refs: nodejs/node#31724
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@codebytere
doc: add directions to mark a release line as lts
b56a21f 
Moves directions for LTS release from the Release repo to Node docs.

Fixes: nodejs/Release#530
PR-URL: #31724
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@codebytere
doc: add directions to mark a release line as lts
3a59805 
Moves directions for LTS release from the Release repo to Node docs.

Fixes: nodejs/Release#530
PR-URL: #31724
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@codebytere
doc: add directions to mark a release line as lts
e791941 
Moves directions for LTS release from the Release repo to Node docs.

Fixes: nodejs/Release#530
PR-URL: #31724
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@codebytere
doc: add directions to mark a release line as lts
448fe39 
Moves directions for LTS release from the Release repo to Node docs.

Fixes: nodejs/Release#530
PR-URL: #31724
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadams danielleadams deleted the add-lts-release-instructions branch March 4, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move steps/process documentation over to nodejs/node
8 participants
@danielleadams @MylesBorins @addaleax @jasnell @richardlau @BethGriggs @BridgeAR @nodejs-github-bot