-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add WASI test for file resizing #31617
Conversation
Looks like the ARM 12 bots were not happy with the new test. Will need to debug. |
What is the current situation with the ARM fanned CI job. I notice that it's inactive, and has been for a while now. That was the only place I was able to see this test fail. Is the ARM fanned job going to be coming back? |
8ae28ff
to
2935f72
Compare
@nodejs/build can you shed some light on the future plans for the ARM fanned CI job (see my previous comment)? |
Yeah, they're offline for now, we just didn't have enough disk to consistently keep them online. The size of the repo & builds just pushes the limits on the disks shared across the cluster. I've come into possession of a new 500Gb SSD that I don't have use for elsewhere that I've started copying data to, it just needs me to allocate the time to reconfigure the NFS mounts to get it all back up again. Will try and not let this slip too much longer. |
arm-fanned back online now and you're getting a clean failure on this: https://ci.nodejs.org/job/node-test-binary-arm-12+/5681/RUN_SUBSET=1,label=pi3-docker/console |
This commit adds a WASI test to cover the following functions: - __wasi_fd_filestat_set_size() - __wasi_fd_tell() PR-URL: nodejs#31617 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit adds a WASI test to cover the following functions: - __wasi_fd_filestat_set_size() - __wasi_fd_tell() PR-URL: #31617 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit adds a WASI test to cover the following functions: - __wasi_fd_filestat_set_size() - __wasi_fd_tell() PR-URL: #31617 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit adds a WASI test to cover the following functions: - __wasi_fd_filestat_set_size() - __wasi_fd_tell() PR-URL: #31617 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit adds a WASI test to cover the following functions: - __wasi_fd_filestat_set_size() - __wasi_fd_tell() PR-URL: #31617 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit adds a WASI test to cover the following functions: - __wasi_fd_filestat_set_size() - __wasi_fd_tell() PR-URL: #31617 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit adds a WASI test to cover the following functions:
__wasi_fd_filestat_set_size()
__wasi_fd_tell()
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes