Skip to content

test: add tests for main() argument handling #31426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2020
Merged

test: add tests for main() argument handling #31426

merged 1 commit into from
Jan 24, 2020

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 20, 2020

This test provides missing coverage for __wasi_args_get() and __wasi_args_sizes_get(), which translate to argc and argv in WASI applications.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 20, 2020
Trott
Trott approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but rubber-stamp on the .wasm file. Would be cool if we could build those rather than check in the .wasm file but I guess that's hard/impossible to do cross-platform and without requiring a mess of new tools or something?

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 23, 2020

Would be cool if we could build those rather than check in the .wasm file but I guess that's hard/impossible to do cross-platform and without requiring a mess of new tools or something?

I'd prefer not needing to check in .wasm files as well. I think the most straightforward way to accomplish that would be for the build machines to have the wasi-sdk installed. I'm not 100% sure if the libc works on every platform that we support (I think it does), and I don't want to volunteer the Build WG for work. make test would also have to know if users have the WASI tools installed locally and skip the WASI tests if they don't.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28598/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 24, 2020 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/28600/ 💚

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 24, 2020
@cjihrig
test: add tests for main() argument handling
748eae9 
This test provides missing coverage for __wasi_args_get() and
__wasi_args_sizes_get(), which translate to argc and argv in
WASI applications.

PR-URL: nodejs#31426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig cjihrig merged commit 748eae9 into nodejs:master Jan 24, 2020
@cjihrig cjihrig deleted the wasi-args branch January 24, 2020 14:44
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@cjihrig @codebytere
test: add tests for main() argument handling
b25ea9b 
This test provides missing coverage for __wasi_args_get() and
__wasi_args_sizes_get(), which translate to argc and argv in
WASI applications.

PR-URL: #31426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@cjihrig @codebytere
test: add tests for main() argument handling
95583df 
This test provides missing coverage for __wasi_args_get() and
__wasi_args_sizes_get(), which translate to argc and argv in
WASI applications.

PR-URL: #31426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@cjihrig @codebytere
test: add tests for main() argument handling
48f4212 
This test provides missing coverage for __wasi_args_get() and
__wasi_args_sizes_get(), which translate to argc and argv in
WASI applications.

PR-URL: #31426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cjihrig @nodejs-github-bot @jasnell @Trott @lpinca