-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: mark Node.js 8 End-of-Life in CHANGELOG #31152
Conversation
on a slightly related note, what do we do with outstanding backport-requested-v8.x PRs and outstanding v8.x issues ? |
@gireeshpunathil - there is no longer a I don't know what we've done historically with issues - but closing any v8.x specific issues with a comment saying Node.js 8 is now End-of-Life and we do not plan to fix the issue (and adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe for a separate PR but it’s probably time to remove the old entries from the bottom of this file (the ones that redirect to the other CHANGELOG files).
I just went through the open v8.x issues and backports and closed them in case they only applied to v8.x and otherwise updated the labels. I also removed all v8.x related labels as they are not relevant anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fasttrack? |
Landed in d845915 |
PR-URL: #31152 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
(I didn't spot another PR open for this)
Checklist