Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,test,tools: forbid usage of v8::Persistent #31018

Closed
wants to merge 4 commits into from
Closed

src,test,tools: forbid usage of v8::Persistent #31018

wants to merge 4 commits into from

Commits on Dec 18, 2019

  1. src,test: use v8::Global instead of v8::Persistent 

    This is in preparation for a lint rule forbidding usage of
`v8::Persistent`.
    @addaleax
    addaleax committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    d89dff2 View commit details
    Browse the repository at this point in the history

  2. fixup! src,test: use v8::Global instead of v8::Persistent

    @addaleax
    addaleax committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    f76f6a8 View commit details
    Browse the repository at this point in the history

  3. doc: avoid using v8::Persistent in addon docs 

    Use `v8::Global` where possible. For examples where it applies,
also clean up the code and make the code multi-threading-ready,
for those where that isn’t easily possible, add a warning about that.
    @addaleax
    addaleax committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    335d450 View commit details
    Browse the repository at this point in the history

  4. tools,src: forbid usage of v8::Persistent 

    `v8::Persistent` comes with the surprising catch that it requires
manual cleanup. `v8::Global` doesn’t, making it easier to use,
and additionally provides move semantics. New code should always
use `v8::Global`.
    @addaleax
    addaleax committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    0c0d530 View commit details
    Browse the repository at this point in the history