Skip to content

test: remove common.busyLoop() #30787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2019
Merged

test: remove common.busyLoop() #30787

merged 2 commits into from
Dec 7, 2019

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 4, 2019 •
edited
Loading

This PR builds on #30784 and #30783.

This commit replaces common.busyLoop() with sleep().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 4, 2019
@cjihrig cjihrig changed the title Busyloop test: remove common.busyLoop() Dec 4, 2019
@cjihrig cjihrig mentioned this pull request Dec 4, 2019
Closed
4 tasks
@addaleax addaleax added the blocked PRs that are blocked by other issues or PRs. label Dec 4, 2019
@cjihrig cjihrig removed the blocked PRs that are blocked by other issues or PRs. label Dec 6, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 6, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27421/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27434/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27435/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 7, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/27436/ 💛

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2019
@cjihrig
util: add internal sleep() function
f446929 
PR-URL: nodejs#30787
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@cjihrig
test: remove common.busyLoop()
aa363c4 
This commit replaces common.busyLoop() with sleep().

PR-URL: nodejs#30787
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@cjihrig cjihrig merged commit aa363c4 into nodejs:master Dec 7, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 7, 2019

Landed in 4ec02d5...aa363c4.

@cjihrig cjihrig deleted the busyloop branch December 7, 2019 03:04
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
@targos targos mentioned this pull request Jan 15, 2020
Closed
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
@benjamingr benjamingr mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cjihrig @nodejs-github-bot @Trott @richardlau @devsnek @addaleax