Skip to content

Conversation

@Trott
Copy link
Member

@Trott Trott commented Nov 30, 2019

Edit text for clarity and readability.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Nov 30, 2019
@Trott Trott requested a review from addaleax November 30, 2019 01:22
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2019
@Trott
Copy link
Member Author

Trott commented Dec 2, 2019

Landed in 7f7d858

@Trott Trott closed this Dec 2, 2019
@Trott Trott deleted the currently branch December 2, 2019 04:52
@Trott Trott merged commit 7f7d858 into nodejs:master Dec 2, 2019
targos pushed a commit that referenced this pull request Dec 2, 2019
Edit text for clarity and readability.

PR-URL: #30723
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
targos pushed a commit that referenced this pull request Dec 5, 2019
Edit text for clarity and readability.

PR-URL: #30723
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
Edit text for clarity and readability.

PR-URL: #30723
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
BethGriggs pushed a commit that referenced this pull request Dec 31, 2019
Edit text for clarity and readability.

PR-URL: #30723
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants