Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: minor updates to releases.md #30636

Closed
wants to merge 1 commit into from
Closed

doc: minor updates to releases.md #30636

wants to merge 1 commit into from

Conversation

BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Nov 25, 2019 •
edited
Loading

Added note about coordinating major releases with npm

//cc @nodejs/release

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 25, 2019
richardlau
richardlau approved these changes Nov 25, 2019
View reviewed changes
doc/releases.md Outdated Show resolved Hide resolved
MylesBorins
MylesBorins approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yorkie
yorkie reviewed Nov 26, 2019
View reviewed changes
doc/releases.md Outdated Show resolved Hide resolved
@BethGriggs
Copy link
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4089/ ✅

@BethGriggs BethGriggs added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 26, 2019
BethGriggs added a commit that referenced this pull request Nov 27, 2019
@BethGriggs
doc: minor updates to releases.md
5904dfc 
PR-URL: #30636
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
@BethGriggs
Copy link
Member Author

Landed in 5904dfc

@BethGriggs BethGriggs closed this Nov 27, 2019
@BethGriggs BethGriggs deleted the release-updates branch November 27, 2019 17:43
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@BethGriggs @addaleax
doc: minor updates to releases.md
3d97883 
PR-URL: #30636
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
@BethGriggs @targos
doc: minor updates to releases.md
857669f 
PR-URL: #30636
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@BethGriggs @MylesBorins
doc: minor updates to releases.md
2532bf3 
PR-URL: #30636
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@yorkie yorkie yorkie approved these changes

@lpinca lpinca lpinca approved these changes

@antsmartian antsmartian antsmartian approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@BethGriggs @MylesBorins @antsmartian @lpinca @yorkie @targos @richardlau @nodejs-github-bot