Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix overriding of prefix option #30518

Closed
wants to merge 1 commit into from
Closed

doc: fix overriding of prefix option #30518

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 17, 2019 •
edited
Loading

Make the example in the "Building a debug build" section work as
intended.

Fixes: #30477

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@lpinca
doc: fix overriding of prefix option
c6e73e5 
Make the example in the "Building a debug build" section work as
intended.

Fixes: nodejs#30477
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 17, 2019
@lundibundi
Copy link
Member

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4077/

@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 18, 2019
trivikr pushed a commit that referenced this pull request Nov 21, 2019
@lpinca @trivikr
doc: fix overriding of prefix option
f4b240f 
Make the example in the "Building a debug build" section work as
intended.

Fixes: #30477

PR-URL: #30518
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@trivikr
Copy link
Member

trivikr commented Nov 21, 2019

Landed in f4b240f

@trivikr trivikr closed this Nov 21, 2019
@lpinca lpinca deleted the gh-30477 branch November 21, 2019 06:19
MylesBorins pushed a commit that referenced this pull request Nov 21, 2019
@lpinca @MylesBorins
doc: fix overriding of prefix option
027bde5 
Make the example in the "Building a debug build" section work as
intended.

Fixes: #30477

PR-URL: #30518
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 21, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@lpinca @targos
doc: fix overriding of prefix option
a992135 
Make the example in the "Building a debug build" section work as
intended.

Fixes: #30477

PR-URL: #30518
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@lpinca @MylesBorins
doc: fix overriding of prefix option
a836ac1 
Make the example in the "Building a debug build" section work as
intended.

Fixes: #30477

PR-URL: #30518
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUILDING.md says "make install --prefix=..." but that doesn't work
5 participants
@lpinca @lundibundi @trivikr @devnexen @nodejs-github-bot