lib: adding optemisation notes, leaving var in place in js_stream_socket.js
#30415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanj
changed the title
var in place for nowvar in place in js_stream_socket.js
ryanj
force-pushed
the
replace-var-with-let-nceu19
branch
from
8b2faa6
to
ec6ad97
Compare
jasnell
approved these changes
Nov 12, 2019
jasnell
added
the
code-and-learn
mscdex
reviewed
Nov 12, 2019
trivikr
approved these changes
Nov 13, 2019
2 tasks
lundibundi
approved these changes
Nov 14, 2019
gireeshpunathil
approved these changes
Nov 16, 2019
ryanj
force-pushed
the
replace-var-with-let-nceu19
branch
from
ec6ad97
to
82689aa
Compare
lundibundi
approved these changes
Nov 24, 2019
lib/internal/js_stream_socket.js
Outdated
| @@ -157,6 +157,7 @@ class JSStreamSocket extends Socket { | |||
| let pending = bufs.length; | |||
|
|
|||
| this.stream.cork(); | |||
| // Prefer `var` over `let` for performance optimization | |||
There was a problem hiding this comment.
Small nit:
Suggested change
| // Prefer `var` over `let` for performance optimization | |
| // Prefer `var` over `let` for performance optimization. |
There was a problem hiding this comment.
thanks @lundibundi. fixed
There was a problem hiding this comment.
reworded, as build results warned: Line should be <= 72 columns
ryanj
force-pushed
the
replace-var-with-let-nceu19
branch
from
82689aa
to
296adc4
Compare
Leaving var in place of let for performance optimization in short loops in hot paths. Added comments explaining why.
ryanj
force-pushed
the
replace-var-with-let-nceu19
branch
from
296adc4
to
0c2391b
Compare
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 26, 2019
Leaving var in place of let for performance optimization in short loops in hot paths. Added comments explaining why. PR-URL: #30415 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
landed in 79e86ac. thanks for the contribution! |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
Leaving var in place of let for performance optimization in short loops in hot paths. Added comments explaining why. PR-URL: #30415 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
Leaving var in place of let for performance optimization in short loops in hot paths. Added comments explaining why. PR-URL: #30415 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Leaving var in place of let for performance optimization in short loops in hot paths. Added comments explaining why. PR-URL: #30415 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @mcollina. Adding comments to explain why
varis preferred overletin this loopChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesDeveloper's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.