Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix numbering in require algorithm #30117

Closed
wants to merge 1 commit into from
Closed

doc: fix numbering in require algorithm #30117

wants to merge 1 commit into from

Conversation

jkrems
Copy link
Contributor

@jkrems jkrems commented Oct 25, 2019

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Oct 25, 2019
@jkrems jkrems mentioned this pull request Oct 25, 2019
Closed
12 tasks
@targos
Copy link
Member

targos commented Oct 25, 2019

I don't know if our doc generator supports it, but normally in markdown you can just put 1. everywhere and the numbering is done automatically

@jkrems
Copy link
Contributor Author

jkrems commented Oct 25, 2019

I don't know if our doc generator supports it, but normally in markdown you can just put 1. everywhere and the numbering is done automatically

Good point and good question. Tried it out locally. The bad news is that it doesn't work, the output preserves the 1s (and as). The good news is that I found another place where the ordering was wrong. In another part of the algorithm a sub-list had two as.

@jkrems jkrems added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 25, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26199/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26201/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26230/

@alexzherdev alexzherdev mentioned this pull request Oct 29, 2019
Closed
4 tasks
jkrems added a commit that referenced this pull request Oct 29, 2019
@jkrems
doc: fix numbering in require algorithm
050a3b1 
Refs: #29327

PR-URL: #30117
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@jkrems
Copy link
Contributor Author

jkrems commented Oct 29, 2019

Landed in 050a3b1

@jkrems jkrems closed this Oct 29, 2019
targos pushed a commit that referenced this pull request Nov 5, 2019
@jkrems @targos
doc: fix numbering in require algorithm
403a648 
Refs: #29327

PR-URL: #30117
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@jkrems @targos
doc: fix numbering in require algorithm
434d24b 
Refs: #29327

PR-URL: #30117
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos
Copy link
Member

targos commented Nov 10, 2019

depends on #29327 to land on v12.x

targos pushed a commit that referenced this pull request Jan 8, 2020
@jkrems @targos
doc: fix numbering in require algorithm
a1b124c 
Refs: #29327

PR-URL: #30117
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jan 8, 2020
@jkrems @targos
doc: fix numbering in require algorithm
31d3864 
Refs: #29327

PR-URL: #30117
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@jkrems @BethGriggs
doc: fix numbering in require algorithm
2d5aec0 
Refs: #29327

PR-URL: #30117
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jkrems @targos @nodejs-github-bot @jasnell @lpinca @cjihrig @trivikr