Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use the WHATWG URL API in http code examples #29917

Closed
wants to merge 1 commit into from
Closed

doc: use the WHATWG URL API in http code examples #29917

wants to merge 1 commit into from

Conversation

watson
Copy link
Member

@watson watson commented Oct 10, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@watson watson added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 10, 2019
@watson watson self-assigned this Oct 10, 2019
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Oct 10, 2019
@watson watson added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2019
@watson
Copy link
Member Author

watson commented Oct 10, 2019

Upvote using 👍 here to approve fast-tracking

@Trott
Copy link
Member

Trott commented Oct 10, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3981/

(@nodejs/github-bot @richardlau It seems like the bot doesn't post the lite CIs automatically anymore for some time. It only posts the full CI runs.)

watson added a commit that referenced this pull request Oct 11, 2019
@watson
doc: use the WHATWG URL API in http code examples
5909532 
PR-URL: #29917
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@watson
Copy link
Member Author

watson commented Oct 11, 2019

Landed in 5909532

@watson watson closed this Oct 11, 2019
@watson watson deleted the url-parse branch October 11, 2019 11:53
@richardlau richardlau mentioned this pull request Oct 11, 2019
Closed
@richardlau
Copy link
Member

(@nodejs/github-bot @richardlau It seems like the bot doesn't post the lite CIs automatically anymore for some time. It only posts the full CI runs.)

@Trott I've reported it over in nodejs/github-bot#246.

targos pushed a commit that referenced this pull request Oct 14, 2019
@watson @targos
doc: use the WHATWG URL API in http code examples
3155ab4 
PR-URL: #29917
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@targos targos mentioned this pull request Oct 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu left review comments

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

@watson watson

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.