doc: fix URLs to CPU/Heap profilers in inspector#29710
Closed
fanatid wants to merge 1 commit intonodejs:masterfrom
Closed
doc: fix URLs to CPU/Heap profilers in inspector#29710fanatid wants to merge 1 commit intonodejs:masterfrom
fanatid wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
jasnell
approved these changes
Sep 26, 2019
lpinca
approved these changes
Sep 26, 2019
lpinca
reviewed
Sep 26, 2019
| [CPU Profiler]: https://chromedevtools.github.io/devtools-protocol/v8/Profiler | ||
| [Chrome DevTools Protocol Viewer]: https://chromedevtools.github.io/devtools-protocol/v8/ | ||
| [Heap Profiler]: https://chromedevtools.github.io/devtools-protocol/v8/HeapProfiler | ||
| [CPU Profiler]: https://chromedevtools.github.io/devtools-protocol/tot/Profiler |
Member
There was a problem hiding this comment.
On second look "tot" stays for tip of the tree while "v8" points to v8-inspector (node) so I think the original is more appropriate?
Contributor
Author
There was a problem hiding this comment.
I just checked again and looks like problem in uBlock Origin. At morning today I received text "404" on page and tot worked. Now I received 404 vs docs. Checked Firefox in incognito with adblocker and sometimes 404, sometimes all fine. Checked in Chrome in incognito (adblocker disabled) and old links works perfect all time.
I think I should close it, no changes required.
Thank you @lpinca
This was referenced May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist