Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: remove ambiguous code #29664

Closed
wants to merge 1 commit into from
Closed

Conversation

ronag
Copy link
Member

@ronag ronag commented Sep 23, 2019

This cleans up some ambiguous code. I don't believe this actually causes any observable change of behaviour.

writable, readable is supposed to indicate the type of the stream, which does not change... this PR makes the code less confusing

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@mscdex
Copy link
Contributor

mscdex commented Sep 23, 2019

s/ambigious/ambiguous/ in commit message

@ronag ronag changed the title stream: remove ambigious code stream: remove ambiguous code Sep 23, 2019
@ronag
Copy link
Member Author

ronag commented Sep 23, 2019

Not sure what you meant. But I'm guess it's the misspelling. Fixed.

@ronag
Copy link
Member Author

ronag commented Sep 23, 2019

@mcollina

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/internal/streams/end-of-stream.js Show resolved Hide resolved
lib/internal/streams/end-of-stream.js Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

JungMinu pushed a commit that referenced this pull request Sep 29, 2019
PR-URL: #29664
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@JungMinu
Copy link
Member

Landed in ce62e96

@JungMinu JungMinu closed this Sep 29, 2019
@BridgeAR BridgeAR added backport-requested-v12.x stream Issues and PRs related to the stream subsystem. labels Oct 9, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Oct 9, 2019

@ronag I guess this depends on other PRs that need backporting first? This currently causes conflicts that are not obvious to resolve. Would you be so kind and check if other PRs need backporting first and add that as well / open a backport if you think that's useful here?

@ronag
Copy link
Member Author

ronag commented Oct 9, 2019

This is probably about to be reverted in #29717 (comment).

I will look into backporting this if/when this becomes relevant again.

@MylesBorins
Copy link
Contributor

quick ping re: backport

ronag added a commit to nxtedition/node that referenced this pull request Jan 18, 2020
PR-URL: nodejs#29664
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
sxa pushed a commit to sxa/node that referenced this pull request Jan 24, 2020
PR-URL: nodejs#29664
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@sxa
Copy link
Member

sxa commented Jan 24, 2020

@MylesBorins In view of 8c60685#diff-009356850b536cab27b019ba8ad15e72 are you sure this should be backported?

@MylesBorins
Copy link
Contributor

Seems like it shouldn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants