inspector: update faviconUrl#29562
Closed
dokugo wants to merge 2 commits intonodejs:masterfrom
dokugo:update-favicon-url
Closed
inspector: update faviconUrl#29562dokugo wants to merge 2 commits intonodejs:masterfrom dokugo:update-favicon-url
dokugo wants to merge 2 commits intonodejs:masterfrom
dokugo:update-favicon-url
Conversation
nodejs-github-bot
added
c++
devnexen
approved these changes
Sep 15, 2019
Contributor
|
Thanks for your contribution. Fine by me just little detail from lint |
lpinca
approved these changes
Sep 15, 2019
ZYSzys
approved these changes
Sep 15, 2019
Member
|
Ping @dokugo , could you please fix the linter so that we can land it ? |
cjihrig
approved these changes
Sep 15, 2019
Contributor
Author
|
Fixed the linter issue. I should have run |
Collaborator
gengjiawen
approved these changes
Sep 16, 2019
BridgeAR
approved these changes
Sep 18, 2019
danbev
added
the
author ready
danbev
pushed a commit
that referenced
this pull request
Oct 4, 2019
PR-URL: #29562 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Contributor
|
Landed in 24d43ca. 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2019
PR-URL: #29562 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This was referenced May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing no icon for the remote target at
chrome://inspect/#deviceswhen debugging via Chrome DevTools with--inspectswitch. GET request for the icon is returning 404 status code because of incorrect request URL: https://nodejs.org/static/favicon.ico.Changed
faviconUrlatsrc/inspector_socket_server.ccto https://nodejs.org/static/images/favicons/favicon.ico. The reason for all this is icon files being moved in nodejs/nodejs.org@ce04045 commit.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes