tools: consistent perms of signed release files #29350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Aug 28, 2019
jasnell
approved these changes
Aug 28, 2019
BethGriggs
approved these changes
Aug 29, 2019
|
thanks for the reviews, will hold this up from landing until it's actually tested by a releaser, after that it can land. |
|
@rvagg I suggest we land this now and we can still revert this if it would turn out not to work as expected? |
BridgeAR
added
the
author ready
Trott
approved these changes
Jan 12, 2020
|
Landed in 625a81d |
Trott
pushed a commit
that referenced
this pull request
Jan 12, 2020
Fixes: nodejs/build#1904 PR-URL: #29350 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
Fixes: nodejs/build#1904 PR-URL: #29350 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
Fixes: nodejs/build#1904 PR-URL: #29350 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Fixes: nodejs/build#1904 PR-URL: #29350 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: nodejs/build#1904
v12.9.1 went out with .sig and .asc files mode 600 so were
403 Forbidden. I believe this is because file permissions are simply copied from what they were when the releaser makes the signature files. All other files in the release directory are already 644 just prior to signing and uploading signed files: https://github.com/nodejs/build/blob/f95ffc8d7d9930f1bc9505b016fdd84711916759/setup/www/tools/promote/_resha.sh#L25-L26This is only testable by a releaser so I'd appreciate the next person doing a release to run this copy of tools/release.sh rather than the one currently on master & v12.x. Once we confirm the release is 👍 we can merge this and make sure it's on all active release branches. @nodejs/releasers.