Skip to content

crypto: simplify DSA validation in FIPS mode #29195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

crypto: simplify DSA validation in FIPS mode #29195

wants to merge 1 commit into from

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Aug 18, 2019

This patch simplifies and deduplicates the DSA parameter validation logic in Sign::Final and SignOneShot.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Aug 18, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25075/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25082/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25083/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 20, 2019
mhdawson
mhdawson approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 20, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25133/

@Trott
Copy link
Member

Trott commented Aug 21, 2019

Landed in 61140ff

@Trott Trott closed this Aug 21, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 21, 2019
@tniessen @Trott
crypto: simplify DSA validation in FIPS mode
61140ff 
PR-URL: nodejs#29195
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@tniessen @BridgeAR
crypto: simplify DSA validation in FIPS mode
e0537e6 
PR-URL: #29195
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@mhdawson mhdawson mhdawson approved these changes

+1 more reviewer

@danbev danbev danbev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tniessen @nodejs-github-bot @Trott @danbev @jasnell @addaleax @mhdawson @BridgeAR