Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: destroy when call settingsFn throw an error #28908

Closed
wants to merge 2 commits into from
Closed

http2: destroy when call settingsFn throw an error #28908

wants to merge 2 commits into from

Conversation

himself65
Copy link
Member

fix #28895

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Jul 31, 2019
lpinca
lpinca approved these changes Jul 31, 2019
View reviewed changes
test/parallel/test-http2-connect.js Outdated Show resolved Hide resolved
@himself65 himself65 force-pushed the 28895 branch 6 times, most recently from 52cde56 to f8371b2 Compare August 1, 2019 06:50
@himself65
Copy link
Member Author

done

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24828/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 2, 2019
@Trott
Copy link
Member

Trott commented Aug 2, 2019

Landed in 2b03e1d

@Trott Trott closed this Aug 2, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 2, 2019
@himself65 @Trott
http2: destroy when settingsFn throws an error
2b03e1d 
http2.connect should call destroy when init fails.

PR-URL: nodejs#28908
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Aug 2, 2019
@himself65 @targos
http2: destroy when settingsFn throws an error
7d9eb17 
http2.connect should call destroy when init fails.

PR-URL: #28908
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@lpinca lpinca mentioned this pull request Aug 5, 2019
Closed
@himself65 himself65 deleted the 28895 branch August 5, 2019 16:47
@BridgeAR BridgeAR mentioned this pull request Aug 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some http2 errors are not captured
6 participants
@himself65 @nodejs-github-bot @Trott @jasnell @lpinca @trivikr