test: refactor test-beforeexit-event-exit using mustNotCall #28901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Jul 30, 2019
Trott
reviewed
Jul 30, 2019
Trott
requested changes
Jul 30, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM once the unused require('assert') is removed.
himself65
force-pushed
the
test-beforeexit-event-exit
branch
from
048f95b to
8ba62c7
Compare
ZYSzys
approved these changes
Jul 31, 2019
Collaborator
Collaborator
Trott
approved these changes
Jul 31, 2019
Trott
added
the
author ready
trivikr
approved these changes
Jul 31, 2019
jasnell
approved these changes
Aug 1, 2019
Member
|
Landed in 980df1c |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 1, 2019
PR-URL: nodejs#28901 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
PR-URL: #28901 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes