stream: readableEnded #28814

ronag · 2019-07-23T07:41:04Z

Adds a readableEnded property and improved finished compat with possible streamlinke objects.

Refs: #28813

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

doc/api/stream.md

mcollina

LGTM

mcollina

Would you mind adding a unit test?

doc/api/stream.md

ronag · 2019-07-23T11:50:34Z

added test

lib/_stream_readable.js

Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>

mcollina

LGTM

nodejs-github-bot · 2019-07-26T05:16:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/24710/

mcollina

LGTM

Trott · 2019-07-26T17:28:59Z

Pinging @nodejs/streams out of caution.

mcollina

There is a nit in the doc

doc/api/stream.md

Co-Authored-By: Matteo Collina <matteo.collina@gmail.com>

test/parallel/test-stream-readable-ended.js

ronag · 2019-08-02T06:30:41Z

@Trott what is this waiting for?

mcollina

LGTM

lib/internal/streams/end-of-stream.js

ronag · 2019-08-19T09:59:04Z

ping @Trott

Trott · 2019-08-19T14:53:18Z

@mcollina Added test looks OK to me. You?

mcollina

LGTM

nodejs-github-bot · 2019-08-19T14:58:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25094/

nodejs-github-bot · 2019-08-19T14:58:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25095/

nodejs-github-bot · 2019-08-20T04:33:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25115/

Trott · 2019-08-20T05:03:41Z

Landed in 317fa3a

Adds a readableEnded property and improved finished compat with possible stream-like objects. PR-URL: #28814 Refs: #28813 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Notable changes: * crypto: * Added an oaepHash option to asymmetric encryption which allows users to specify a hash function when using OAEP padding. #28335 * deps: * Updated V8 to 7.6.303.29. #28955 * Improves the performance of various APIs such as `JSON.parse` and methods called on frozen arrays. * Adds the Promise.allSettled method. * Improves support of `BigInt` in `Intl` methods. * For more information: https://v8.dev/blog/v8-release-76 * Updated libuv to 1.31.0. #29070 * `UV_FS_O_FILEMAP` has been added for faster access to memory mapped files on Windows. * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on Windows. It previously returned `UV_ENOENT`. * The `uv_fs_statfs()` API has been added. * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been added. * fs: * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise version) methods. They allow to write an array of `ArrayBufferView`s to a file descriptor. #25925 https://github.com/nodejs/node/pull/29186/files * http: * Added three properties to `OutgoingMessage.prototype`: `writableObjectMode`, `writableLength` and `writableHighWaterMark` #29018 * stream: * Added an new property `readableEnded` to readable streams. Its value is set to `true` when the `'end'` event is emitted. #28814 * Added an new property `writableEnded` to writable streams. Its value is set to `true` after `writable.end()` has been called. #28934 PR-URL: #29210

Notable changes: * crypto: * Added an oaepHash option to asymmetric encryption which allows users to specify a hash function when using OAEP padding. nodejs#28335 * deps: * Updated V8 to 7.6.303.29. nodejs#28955 * Improves the performance of various APIs such as `JSON.parse` and methods called on frozen arrays. * Adds the Promise.allSettled method. * Improves support of `BigInt` in `Intl` methods. * For more information: https://v8.dev/blog/v8-release-76 * Updated libuv to 1.31.0. nodejs#29070 * `UV_FS_O_FILEMAP` has been added for faster access to memory mapped files on Windows. * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on Windows. It previously returned `UV_ENOENT`. * The `uv_fs_statfs()` API has been added. * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been added. * fs: * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise version) methods. They allow to write an array of `ArrayBufferView`s to a file descriptor. nodejs#25925 https://github.com/nodejs/node/pull/29186/files * http: * Added three properties to `OutgoingMessage.prototype`: `writableObjectMode`, `writableLength` and `writableHighWaterMark` nodejs#29018 * stream: * Added an new property `readableEnded` to readable streams. Its value is set to `true` when the `'end'` event is emitted. nodejs#28814 * Added an new property `writableEnded` to writable streams. Its value is set to `true` after `writable.end()` has been called. nodejs#28934 PR-URL: nodejs#29210

Notable changes: * crypto: * Added an oaepHash option to asymmetric encryption which allows users to specify a hash function when using OAEP padding. #28335 * deps: * Updated V8 to 7.6.303.29. #28955 * Improves the performance of various APIs such as `JSON.parse` and methods called on frozen arrays. * Adds the Promise.allSettled method. * Improves support of `BigInt` in `Intl` methods. * For more information: https://v8.dev/blog/v8-release-76 * Updated libuv to 1.31.0. #29070 * `UV_FS_O_FILEMAP` has been added for faster access to memory mapped files on Windows. * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on Windows. It previously returned `UV_ENOENT`. * The `uv_fs_statfs()` API has been added. * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been added. * fs: * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise version) methods. They allow to write an array of `ArrayBufferView`s to a file descriptor. #25925 #29186 * http: * Added three properties to `OutgoingMessage.prototype`: `writableObjectMode`, `writableLength` and `writableHighWaterMark` #29018 * stream: * Added an new property `readableEnded` to readable streams. Its value is set to `true` when the `'end'` event is emitted. #28814 * Added an new property `writableEnded` to writable streams. Its value is set to `true` after `writable.end()` has been called. #28934 PR-URL: #29210

nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Jul 23, 2019

ronag changed the title ~~Stream readable finished~~ stream: readableEnded Jul 23, 2019

ronag force-pushed the stream-readableFinished branch 2 times, most recently from 9f98db0 to 45d181d Compare July 23, 2019 07:48

vsemozhetbyt reviewed Jul 23, 2019

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

ronag force-pushed the stream-readableFinished branch from 45d181d to 11f8b89 Compare July 23, 2019 10:15

mcollina approved these changes Jul 23, 2019

View reviewed changes

mcollina requested changes Jul 23, 2019

View reviewed changes

vsemozhetbyt reviewed Jul 23, 2019

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

ronag force-pushed the stream-readableFinished branch 2 times, most recently from 82e0c54 to 34a2d13 Compare July 23, 2019 11:50

stream: add readableEnded

c446fcd

ronag force-pushed the stream-readableFinished branch from 34a2d13 to c446fcd Compare July 23, 2019 11:52

lpinca reviewed Jul 23, 2019

View reviewed changes

lib/_stream_readable.js Outdated Show resolved Hide resolved

Update lib/_stream_readable.js

dd03ec5

Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>

mcollina approved these changes Jul 24, 2019

View reviewed changes

mcollina approved these changes Jul 26, 2019

View reviewed changes

Trott added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 26, 2019

Trott approved these changes Jul 26, 2019

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 26, 2019

mcollina requested changes Jul 26, 2019

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

trivikr removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 26, 2019

Update doc/api/stream.md

a51944f

Co-Authored-By: Matteo Collina <matteo.collina@gmail.com>

wa-Nadoo reviewed Jul 27, 2019

View reviewed changes

test/parallel/test-stream-readable-ended.js Outdated Show resolved Hide resolved

mcollina approved these changes Aug 2, 2019

View reviewed changes

mcollina requested changes Aug 2, 2019

View reviewed changes

lib/internal/streams/end-of-stream.js Outdated Show resolved Hide resolved

mcollina approved these changes Aug 19, 2019

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 19, 2019

Trott closed this Aug 20, 2019

targos mentioned this pull request Aug 20, 2019

v12.9.0 release proposal #29210

Merged

ad-m mentioned this pull request Jan 29, 2020

Pipe to Channel hangs on "Parser: IN_PACKETBEFORE (expecting 16)" mscdex/ssh2#870

Closed

chudley mentioned this pull request Mar 27, 2020

MANTA-4341 Optimize conditional object operations TritonDataCenter/node-manta#382

Merged

Uh oh!

stream: readableEnded #28814

stream: readableEnded #28814

Uh oh!

Conversation

ronag commented Jul 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ronag commented Jul 23, 2019

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jul 26, 2019

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Jul 26, 2019

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ronag commented Aug 2, 2019

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ronag commented Aug 19, 2019

Uh oh!

Trott commented Aug 19, 2019

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 19, 2019

Uh oh!

nodejs-github-bot commented Aug 19, 2019

Uh oh!

nodejs-github-bot commented Aug 20, 2019

Uh oh!

Trott commented Aug 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ronag commented Jul 23, 2019 •

edited

Loading