Skip to content

doc: writableFinished is true before 'finish' #28811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

doc: writableFinished is true before 'finish' #28811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion doc/api/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1473,7 +1473,9 @@ added: REPLACEME

* {boolean}

Is `true` if all data has been flushed to the underlying system.
Is `true` if all data has been flushed to the underlying system and
immediately before the [`'finish'`][] event is emitted.


### response.writeContinue()
<!-- YAML
Expand Down Expand Up @@ -2191,6 +2193,7 @@ not abort the request or do anything besides add a `'timeout'` event.
[`agent.createConnection()`]: #http_agent_createconnection_options_callback
[`agent.getName()`]: #http_agent_getname_options
[`destroy()`]: #http_agent_destroy
[`'finish'`]: #http_event_finish
[`getHeader(name)`]: #http_request_getheader_name
[`http.Agent`]: #http_class_http_agent
[`http.ClientRequest`]: #http_class_http_clientrequest
Expand Down
2 changes: 1 addition & 1 deletion doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ added: v12.6.0

* {boolean}

Is `true` if after the [`'finish'`][] event has been emitted.
Is set to `true` immediately before the [`'finish'`][] event is emitted.

##### writable.writableHighWaterMark
<!-- YAML
Expand Down