build: update Windows icon to Feb 2016 node rebrand

[mikemaccana]

Fixes #27934

[mikemaccana]

Hi @nodejs-github-bot , this isn't C++. I suspect you're not very clever though and won't understand this message.

[devsnek]

@mikemaccana can you update the commit message to adhere to our commit guidelines?

i think

build: update Windows icon to Feb 2016 node rebrand

Refs: https://github.com/nodejs/node/issues/27934

would do the trick

[mikemaccana]

Sure @devsnek, done.

[silverwind]

Just noticed the icon has some minor imperfections at the top and bottom-right edges of the hexagon which are also present in the source SVG, no idea how I could've missed those. I'll have a look at fixing them.

[mikemaccana]

@silverwind Do you mean in the source file at https://github.com/nodejs/nodejs.org/blob/master/static/images/logo-hexagon.svg?

Yeah I noticed those too. Here's a screenshot for anyone else:

They'll affect people using the node logo at high resolution in banners / slideshows at events etc. but theyy don't have much of an effect att 256 x 256 (this PR). Worth making a separate issue for them.

[silverwind]

Yes, the full logo does not show the issue, so it must've been introduced when extracting the hexagon from it. I'll have a PR against the website up soon with a fix, ideally you could then regenerate the .ico from it.

[silverwind]

nodejs/nodejs.org#2316

[mikemaccana]

ideally you could then regenerate the .ico from it.

@silverwind no probs, done.

[trivikr]

The original icon is 128x128 (link)
Is there a reason to update it to 256x256 resolution? (link)

[mikemaccana]

Yep, 256 is used on high resolution displays.

See the Windows Icon guidelines:
https://docs.microsoft.com/en-us/windows/desktop/uxguide/vis-icons

Application icons and Control Panel items: The full set includes 16x16, 32x32, 48x48, and 256x256 (code scales between 32 and 256). The .ico file format is required. For Classic Mode, the full set is 16x16, 24x24, 32x32, 48x48 and 64x64.

[silverwind]

Which sizes are included here, by the way?

Edit: It's mentioned in #27934 (comment)

[BridgeAR]

I believe there's nothing that our CI could detect here, so I'll mark it as author-ready even without a CI run.

[silverwind]

If someone on Windows could verify that the built node.exe gets the right icon, I think this is good to land.

[Trott]

If someone on Windows could verify that the built node.exe gets the right icon, I think this is good to land.

@nodejs/platform-windows

[bzoz]

With this PR it gets this icon:

[silverwind]

Thanks @bzoz. Landed in 012ed49.