tools: change editorconfig's 'ignore' to 'unset'#28440
Closed
silverwind wants to merge 1 commit intonodejs:masterfrom
Closed
tools: change editorconfig's 'ignore' to 'unset'#28440silverwind wants to merge 1 commit intonodejs:masterfrom
silverwind wants to merge 1 commit intonodejs:masterfrom
Conversation
According to https://editorconfig.org/#supported-properties the canonical way to disable a property is to set it to 'unset'. We did use 'ignore' and this generally works because tools ignore unknown values but some of them like `eclint` are picky on it.
Trott
approved these changes
Jun 27, 2019
trivikr
approved these changes
Jun 27, 2019
|
Any "invalid" value and the property should be ignored. Use But the "official" way is to set them to |
lpinca
approved these changes
Jun 27, 2019
Contributor
Author
|
Thanks, landed in a173173. |
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
According to https://editorconfig.org/#supported-properties the canonical way to disable a property is to set it to 'unset'. We did use 'ignore' and this generally works because tools ignore unknown values but some of them like `eclint` are picky on it. PR-URL: #28440 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
According to https://editorconfig.org/#supported-properties the canonical way to disable a property is to set it to 'unset'. We did use 'ignore' and this generally works because tools ignore unknown values but some of them like `eclint` are picky on it. PR-URL: #28440 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://editorconfig.org/#supported-properties the canonical way to disable a property is to set it to 'unset'. We did use 'ignore' and this generally works because tools ignore unknown values but some of them like
eclintare picky on it.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes