test: tsl switch arguments order for the assertion#28340
Closed
ltciro wants to merge 1 commit intonodejs:masterfrom
ltciro:fix-test-tls-net-connect
Closed
test: tsl switch arguments order for the assertion#28340ltciro wants to merge 1 commit intonodejs:masterfrom ltciro:fix-test-tls-net-connect
ltciro wants to merge 1 commit intonodejs:masterfrom
ltciro:fix-test-tls-net-connect
Conversation
addaleax
approved these changes
Jun 21, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
The commit message has a typo, I think (tls vs tsl), but that can also be taken care of when landing the PR :)
Trott
approved these changes
Jun 21, 2019
cjihrig
approved these changes
Jun 21, 2019
ZYSzys
approved these changes
Jun 22, 2019
ZYSzys
added
the
code-and-learn
BridgeAR
approved these changes
Jun 22, 2019
BridgeAR
added
the
author ready
trivikr
approved these changes
Jun 23, 2019
jasnell
approved these changes
Jun 23, 2019
Member
|
Landed in 9a41aa1 Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
pull bot
pushed a commit
to tkamenoko/node
that referenced
this pull request
Jun 25, 2019
PR-URL: nodejs#28340 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
PR-URL: #28340 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: tsl switch arguments order for the assertion
Switch the argument order for the assertion to be in the correct order (
actual,expected)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes